public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Trimarchi <trimarchimichael@yahoo.it>
To: linux-sh@vger.kernel.org
Subject: Re: SH7722 serial scif
Date: Thu, 25 Sep 2008 09:17:20 +0000	[thread overview]
Message-ID: <89238.65070.qm@web26208.mail.ukl.yahoo.com> (raw)
In-Reply-To: <878566.91579.qm@web26201.mail.ukl.yahoo.com>

Hi,

...


> Ok, that's interesting. There are a couple things to consider here:
> 
>     - startup/shutdown both set and clear the RX and TX IRQ enable
>       bits
>     - the base SCSCR initialization is maintained across the lifetime
>       of the port, and is directly manipulated by the termios value.
> 
> We need the initialization in the set_termios path for things like the
> system console, which can be suspended/resumed, as well as handling
> rate changes directly (not related to the frequency notifier).
> 
> Given that, moving this out to the startup/shutdown path is definitely
> not what we want to do, but we do need to figure out what your SCSCR
> register state is at the time of startup and shutdown. There are a couple
> of possibilities:
> 
>     - IRQ not properly acked and cleared at shutdown time, despite
>       the TX/RX bits being cleared.
>     - Some bit setting in the SCSCR_INIT definition for your platform
>       that we need to be more careful in handling.
> 
> If we look at the setting for 7722, it's the usual mix of TE/RE/REIE and
> nothing particularly exotic, so we can probably just swallow these up in
> the sci_start_tx/rx()/sci_stop_tx/rx() pairs, and that should
> subsequently get your SCSCR value pretty much back to 0 at shutdown time.

After revert my code, and take a look to the SCSCR register before
open and shutdown, this is the result. 

I found a SCSCR equal to 0x38 after and before, so the bit are not cleared but if I do an sci_out of 0
to the register, all seems to be ok.

It is very strange, it seems the SCSCR status does't change
after the sci_stop_tx e sci_stop_rx


Any idea?

Regards Michael

__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi 
http://mail.yahoo.it 

  parent reply	other threads:[~2008-09-25  9:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24 14:52 SH7722 serial scif Michael Trimarchi
2008-09-24 15:49 ` Paul Mundt
2008-09-24 15:57 ` Michael Trimarchi
2008-09-24 16:43 ` Paul Mundt
2008-09-25  9:17 ` Michael Trimarchi [this message]
2008-09-27 17:12 ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89238.65070.qm@web26208.mail.ukl.yahoo.com \
    --to=trimarchimichael@yahoo.it \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox