From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 16 Feb 2010 08:12:09 +0000 Subject: Re: [PATCH] ptrace: unify FDPIC implementations Message-Id: <8bd0f97a1002160012x2736f2b1r1ea4e57c41cf7fbb@mail.gmail.com> List-Id: References: <1266280229-18469-1-git-send-email-vapier@gentoo.org> <20100216011041.GB4889@linux-sh.org> In-Reply-To: <20100216011041.GB4889@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Paul Mundt Cc: Andrew Morton , linux-kernel@vger.kernel.org, Roland McGrath , David Howells , Oleg Nesterov , uclinux-dist-devel@blackfin.uclinux.org, linux-sh@vger.kernel.org On Mon, Feb 15, 2010 at 20:10, Paul Mundt wrote: > On Mon, Feb 15, 2010 at 07:30:29PM -0500, Mike Frysinger wrote: >> The Blackfin/FRV/SuperH guys all have the same exact FDPIC ptrace code in >> their arch handlers (since they were probably copied & pasted). =C2=A0Si= nce >> these ptrace interfaces are an arch independent aspect of the FDPIC code, >> unify them in the common ptrace code so new FDPIC ports don't need to co= py >> and paste this fundamental stuff yet again. >> >> Signed-off-by: Mike Frysinger >> Acked-by: Roland McGrath >> Acked-by: David Howells >> Acked-by: Paul Mundt > > Just to follow up on this, this code obviously expects consistent entries > in mm_context_t. Presently include/asm-generic/mmu.h is aimed at nommu, > so it would probably be worthwhile stubbing in the FDPIC loadmap entries > there to make things easier for future ports. probably be a good idea. for FDPIC in general, the header also needs "stack_start". -mike