From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT
Date: Thu, 05 Dec 2013 05:56:48 +0000 [thread overview]
Message-ID: <9848623.yKHAtIGPld@avalon> (raw)
In-Reply-To: <20131205034554.GB20388@verge.net.au>
Hi Simon,
On Thursday 05 December 2013 12:45:54 Simon Horman wrote:
> On Thu, Nov 28, 2013 at 04:44:53PM +0100, Laurent Pinchart wrote:
> > The mandatory regulator-type property is missing, add it.
>
> Thanks, I will queue this up.
Mark has rightfully commented on patch 1/2 in this series that the regulator-
type property shouldn't be mandatory but should default to voltage. We could
then drop this patch.
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> > b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index
> > 7b80f19..013a7cd 100644
> > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> > @@ -53,6 +53,8 @@
> >
> > regulator-name = "SDHI0 VccQ";
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <3300000>;
> >
> > + regulator-type = "voltage";
> > +
> >
> > vin-supply = <&vcc_sdhi0>;
> >
> > enable-gpio = <&pfc 74 GPIO_ACTIVE_HIGH>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-05 5:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 15:44 [PATCH 0/2] Document GPIO regulator regulator-type property and use it Laurent Pinchart
2013-11-28 15:44 ` [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property Laurent Pinchart
2013-12-05 0:09 ` Mark Brown
2013-12-05 0:47 ` Laurent Pinchart
2014-05-13 0:06 ` Laurent Pinchart
2014-05-13 16:59 ` Mark Brown
2014-05-21 13:44 ` Laurent Pinchart
2014-05-21 14:22 ` Mark Brown
2013-11-28 15:44 ` [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT Laurent Pinchart
2013-12-05 3:45 ` Simon Horman
2013-12-05 5:56 ` Laurent Pinchart [this message]
2013-12-05 6:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9848623.yKHAtIGPld@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).