linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 08/08] sh: Move new memblock reservation code to drivers/sh
Date: Fri, 07 Jan 2011 01:15:22 +0000	[thread overview]
Message-ID: <AANLkTimyBJVQevTuxixaxj4Ahq6n=cvN7uMYPULV7kSL@mail.gmail.com> (raw)
In-Reply-To: <20110106101659.1617.32582.sendpatchset@t400s>

On Fri, Jan 7, 2011 at 1:02 AM, Masao Uebayashi <uebayasi@tombi.co.jp> wrote:
> On Thu, Jan 06, 2011 at 07:16:59PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Move the new physically contiguous memory reservation
>> code from arch/sh into drivers/sh/memchunk.c to it can
>> be shared with SH-Mobile / R-Mobile ARM processors.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>> ---
>>
>>  arch/sh/mm/consistent.c |   58 ----------------------------------
>>  drivers/sh/Makefile     |    1
>>  drivers/sh/memchunk.c   |   78 +++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 79 insertions(+), 58 deletions(-)

Hi Uebayashi-san,

> Why do you have two copies of shmobile_memchunk_setup() in
> arch/sh/mm/consistent.c and here?
>
> Masao (new to this list)

The patch should move the function into drivers/sh, but perhaps I made
some mistake. So there shouldn't be two copies of the same function,
not sure how you get that.

Thanks,

/ magnus

      parent reply	other threads:[~2011-01-07  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 10:16 [PATCH 08/08] sh: Move new memblock reservation code to drivers/sh Magnus Damm
2011-01-06 16:02 ` [PATCH 08/08] sh: Move new memblock reservation code to Masao Uebayashi
2011-01-07  1:15 ` Magnus Damm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimyBJVQevTuxixaxj4Ahq6n=cvN7uMYPULV7kSL@mail.gmail.com' \
    --to=magnus.damm@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).