From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Wed, 16 Jun 2010 07:58:41 +0000 Subject: Re: [PATCH v2] soc/sh: Fix I2C dependency for SND_FSI_AK4642 and SND_FSI_DA7210 Message-Id: List-Id: References: <201006141739.42346.PeterHuewe@gmx.de> <201006151649.07554.PeterHuewe@gmx.de> <20100615151913.GJ14510@rakim.wolfsonmicro.main> <201006151738.56143.PeterHuewe@gmx.de> <20100616035440.GA29614@linux-sh.org> <250A6DE6-BB14-42F7-9500-A479C8FCA9B3@opensource.wolfsonmicro.com> <20100616074947.GC29614@linux-sh.org> (sfid-20100616_085006_460441_D8011665) In-Reply-To: <20100616074947.GC29614@linux-sh.org> (sfid-20100616_085006_460441_D8011665) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mundt Cc: Peter Huewe , Liam Girdwood , linux-sh@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Guennadi Liakhovetski , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org On 16 Jun 2010, at 08:49, Paul Mundt wrote: > On Wed, Jun 16, 2010 at 08:43:33AM +0100, Mark Brown wrote: >> Since these are board specific drivers they know which I2C controller they are >> hooked up to and so can usefully depend on a specific controller - without the >> correct controller driver they will not function. > I don't really mind one way or the other. Having it depend on the > controller is fine, but it's not really much of a stretch to expect it to > show up on other boards with other controllers as well. This is the driver for the board itself and its wiring - it's not a chip driver, it's the driver that says how the chips on a given board are connected. For new boards I'd expect you'd end up with a new driver.