From: Mike Frysinger <vapier@gentoo.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-sh@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/5] asm-generic/ptrace.h: start a common low level ptrace helper
Date: Thu, 14 Apr 2011 18:16:03 +0000 [thread overview]
Message-ID: <BANLkTikxq-xUhYmbE93+aGHoiEEbHWkoWQ@mail.gmail.com> (raw)
In-Reply-To: <20110414180936.GA20924@redhat.com>
On Thu, Apr 14, 2011 at 14:09, Oleg Nesterov wrote:
> On 04/14, Mike Frysinger wrote:
>> +#ifndef GET_IP
>> +#define GET_IP(regs) ((regs)->pc)
>> +#endif
>
> Could you explain this ifndef ?
>
> IIUC, this should be included by arch/*/asm/ptrace.h. Isn't it better
> to simply require that if you include asm-generic/ptrace.h you should
> provide the necessary GET_* macros?
>
> (regs)->pc looks a bit strange in asm-generic. But please feel free
> to ignore.
my view of asm-generic is to put as much common/sane-defaults in there
as possible to minimize code duplication in arch code. when it comes
to the register names, i looked at the arches to see what people used.
while x86 uses "ip", the majority of ports use "pc", thus the
majority of ports wont have to define their own GET_IP helper.
-mike
next prev parent reply other threads:[~2011-04-14 18:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 6:01 [PATCH 0/5] ptrace low level unification Mike Frysinger
2011-04-14 6:01 ` [PATCH 1/5] asm-generic/ptrace.h: start a common low level ptrace helper Mike Frysinger
2011-04-14 18:09 ` [PATCH 1/5] asm-generic/ptrace.h: start a common low level Oleg Nesterov
2011-04-14 18:16 ` Mike Frysinger [this message]
2011-04-14 6:01 ` [PATCH 2/5] Blackfin: convert to asm-generic ptrace.h Mike Frysinger
2011-04-14 6:01 ` [PATCH 3/5] x86: " Mike Frysinger
2011-04-14 14:16 ` [Kgdb-bugreport] " Sergei Shtylyov
2011-04-14 17:05 ` H. Peter Anvin
2011-04-14 17:38 ` Sergei Shtylyov
2011-04-14 6:01 ` [PATCH 4/5] sh: " Mike Frysinger
2011-04-14 14:22 ` [Kgdb-bugreport] " Sergei Shtylyov
2011-04-16 19:17 ` Paul Mundt
2011-04-14 6:01 ` [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment Mike Frysinger
2011-04-18 8:29 ` Paul Mundt
2011-06-16 15:07 ` Arnd Bergmann
2011-06-16 20:06 ` Mike Frysinger
2011-06-16 20:07 ` Mike Frysinger
2011-06-16 20:21 ` Arnd Bergmann
2011-06-16 20:29 ` Mike Frysinger
2011-04-19 5:36 ` [Kgdb-bugreport] [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint DDD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikxq-xUhYmbE93+aGHoiEEbHWkoWQ@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).