From: Magnus Damm <magnus.damm@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-input@vger.kernel.org, lethal@linux-sh.org,
dmitry.torokhov@gmail.com, linux-sh@vger.kernel.org
Subject: Re: [PATCH] input: sh_keysc: 8x8 MODE_6 fix
Date: Thu, 16 Jun 2011 00:57:57 +0000 [thread overview]
Message-ID: <BANLkTim+W2zvHY9jTOPM=iFPrB4tB0vmNQ@mail.gmail.com> (raw)
In-Reply-To: <20110615231211.GC28947@verge.net.au>
On Thu, Jun 16, 2011 at 8:12 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jun 15, 2011 at 11:33:40PM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> The MODE_6 support in sh_keysc.c is incorrect without
>> this patch. According to the data sheet for G4, AP4 and
>> AG5 KEYSC MODE_6 is 8x8 keys. Bump up MAXKEYS to 64 too.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>
> Reviewed-by: Simon Horman <horms@verge.net.au>
Thanks!
> Do we also need to update the platform data for ag5evm
> which is currently using SH_KEYSC_MODE_6 but with 49
> entries in its keysc_platdata.keycodes ?
Yes, eventually we need to update the board support code as well.
Chances are that existing out-of-tree board support code is broken. So
we need updated platform data together with a pinmux configuration
that matches the board schematics. Tested on real hardware using
evtest.
Cheers,
/ magnus
next prev parent reply other threads:[~2011-06-16 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 14:33 [PATCH] input: sh_keysc: 8x8 MODE_6 fix Magnus Damm
2011-06-15 23:12 ` Simon Horman
2011-06-16 0:57 ` Magnus Damm [this message]
2011-06-18 9:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTim+W2zvHY9jTOPM=iFPrB4tB0vmNQ@mail.gmail.com' \
--to=magnus.damm@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=horms@verge.net.au \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox