From: Magnus Damm <magnus.damm@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org,
horms@verge.net.au, mst@redhat.com, iws@ovro.caltech.edu
Subject: Re: [PATCH 02/02] virtio: Add virtio platform driver
Date: Thu, 23 Jun 2011 02:26:34 +0000 [thread overview]
Message-ID: <BANLkTimSj9iMeYJ8X7SCocVDfbGUPGotRw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=tut=Y4fc4tkT8wt_q1azJOYaDoQ@mail.gmail.com>
Hi Mike,
On Wed, Jun 22, 2011 at 3:27 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tue, Jun 21, 2011 at 06:26, Magnus Damm wrote:
>> +config VIRTIO_PLATFORM
>> + tristate "Platform driver for virtio devices (EXPERIMENTAL)"
>> + select VIRTIO
>> + select VIRTIO_RING
>> + select VIRTIO_LGUEST
>> + ---help---
>> + This drivers provides support for virtio based paravirtual device
>> + drivers over a platform bus.
>> +
>> + If unsure, say N.
>
> be nice to add a note as to the name of the module if the user selects "M"
Yes, good idea!
>> --- /dev/null
>> +++ work/drivers/virtio/virtio_platform.c 2011-03-03 16:07:31.000000000 +0900
>> --- /dev/null
>> +++ work/include/linux/virtio_platform.h 2011-03-03 15:56:54.000000000 +0900
>
> both files lack a comment block at the top
> /*
> * one line desc of file
> *
> * copyright
> *
> * license blurb
> */
Sure! I will include these changes in the next version!
Thank you!
/ magnus
next prev parent reply other threads:[~2011-06-23 2:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 10:26 [PATCH 00/02][RESEND] virtio: Virtio platform driver Magnus Damm
2011-06-21 10:26 ` [PATCH 01/02] virtio: Break out lguest virtio code to virtio_lguest.c Magnus Damm
2011-06-21 10:26 ` [PATCH 02/02] virtio: Add virtio platform driver Magnus Damm
2011-06-21 18:27 ` Mike Frysinger
2011-06-23 2:26 ` Magnus Damm [this message]
2011-06-23 8:54 ` Bhushan Bharat-R65777
2011-06-24 1:14 ` Magnus Damm
2011-06-24 4:08 ` Bhushan Bharat-R65777
2011-06-22 2:21 ` [PATCH 00/02][RESEND] virtio: Virtio " Rusty Russell
2011-06-28 5:14 ` Magnus Damm
-- strict thread matches above, loose matches on Subject: below --
2011-03-10 7:05 [PATCH 00/02] " Magnus Damm
2011-03-10 7:06 ` [PATCH 02/02] virtio: Add virtio " Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimSj9iMeYJ8X7SCocVDfbGUPGotRw@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=horms@verge.net.au \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=vapier@gentoo.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).