From mboxrd@z Thu Jan 1 00:00:00 1970 From: MyungJoo Ham Date: Wed, 04 May 2011 08:43:19 +0000 Subject: Re: [linux-pm] [RFC][PATCH 1/2] PM / Runtime: Support for generic I/O Message-Id: List-Id: References: <201104290154.12966.rjw@sisk.pl> <201104290154.56145.rjw@sisk.pl> <201104292211.03702.rjw@sisk.pl> In-Reply-To: <201104292211.03702.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: "Rafael J. Wysocki" Cc: Linux PM mailing list , linux-sh@vger.kernel.org, Greg KH , LKML , Grant Likely On Sat, Apr 30, 2011 at 5:11 AM, Rafael J. Wysocki wrote: > > Well, not really. =A0There are a few things to consider. > > First, in general, there may be devices that have a real parent and belong > to a power domain at the same time, so we can't "steal" the parent > pointers from them. Ah. right we only have one parent per device. Ok, setting a power domain as a device's parent is not going to work for some devices. However, I have some other questions. 1. pm_genpd_runtime_suspend and pm_genpd_runtime_resume are opened to outside (not static and "extern"ed). Are devices supposed to call pm_genpd_runtime_* directly? Shouldn't they be hidden so that devices are forced to turn on/off power domains with runtime_pm framework only? Is there any reason to expose them? 2. If we can assure that related clocks are not turned on when a power domain is shutting down, it'd be nice. I guess it would be sufficient to let it "WARN" at gov->power_down_ok(). Is it the intention of governor? Thank you! I also think this is going to help us a lot, too :) - MyungJoo --=20 MyungJoo Ham, Ph.D. Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: 82-10-6714-2858