* superh perf events broken ?
@ 2011-05-06 14:14 Mike Frysinger
0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2011-05-06 14:14 UTC (permalink / raw)
To: linux-sh
unless i'm missing something, it seems the core
sh/kernel/perf_events.c code broke at some point. the events[] array
is updated in sh_pmu_{start,stop}, but no one ever reads it. when i
look at the alpha version, that events array is walked in the
pmu_enable step before setting the global enable bit while in the
superh one, only the global enable bit is set.
so it seems like the superh pmu_enable func too should walk its
events[] array to update its settings before enabling things ...
otherwise, the whole events[] array maintenance is pointless ...
-mike
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-05-06 14:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-06 14:14 superh perf events broken ? Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).