From: Bastian Hecht <hechtb@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
Date: Thu, 15 Nov 2012 09:13:51 +0000 [thread overview]
Message-ID: <CABYn4szNs0VnNB-q_8hQdp1gP+5op-Km6A3f1vfUn-vmEDGvGQ@mail.gmail.com> (raw)
In-Reply-To: <1352803609-16669-1-git-send-email-hechtb@gmail.com>
Hello Simon,
> could you provide a little more information on:
> * Why this is so. Is it related to a change in another commit?
Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd:
sh_flctl: Add support for error IRQ.
It notifies us when the actual communication from our flash controller
to the NAND chip fails.
> * What the implications are of this change not being applied:
> the driver doesn't work?
Yes the driver refuses to start up if the error IRQ is missing.
Do you think I should include such information into the commit
message, or is it just helpful for the upstream process?
Cheers,
Bastian
next prev parent reply other threads:[~2012-11-15 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
2012-11-14 23:22 ` Simon Horman
2012-11-15 9:13 ` Bastian Hecht [this message]
2012-11-16 0:02 ` Simon Horman
2012-11-20 0:05 ` Bastian Hecht
2012-11-20 0:43 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2012-11-19 1:24 [GIT PULL] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
2012-11-19 1:24 ` [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Simon Horman
2012-11-19 12:30 ` Sergei Shtylyov
2012-11-20 0:03 ` Simon Horman
2012-11-20 0:43 [GIT PULL v2] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
2012-11-20 0:43 ` [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABYn4szNs0VnNB-q_8hQdp1gP+5op-Km6A3f1vfUn-vmEDGvGQ@mail.gmail.com \
--to=hechtb@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).