From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Hecht Date: Thu, 15 Nov 2012 09:13:51 +0000 Subject: Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Message-Id: List-Id: References: <1352803609-16669-1-git-send-email-hechtb@gmail.com> In-Reply-To: <1352803609-16669-1-git-send-email-hechtb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello Simon, > could you provide a little more information on: > * Why this is so. Is it related to a change in another commit? Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd: sh_flctl: Add support for error IRQ. It notifies us when the actual communication from our flash controller to the NAND chip fails. > * What the implications are of this change not being applied: > the driver doesn't work? Yes the driver refuses to start up if the error IRQ is missing. Do you think I should include such information into the commit message, or is it just helpful for the upstream process? Cheers, Bastian