[PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Bastian Hecht]

The FLCTL driver now requires the resource of the error IRQ.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 0c27c81..66ec616 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {
-- 
1.7.9.5

Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Simon Horman]

On Tue, Nov 13, 2012 at 11:46:49AM +0100, Bastian Hecht wrote:
> The FLCTL driver now requires the resource of the error IRQ.

Hi Bastian,

could you provide a little more information on:
* Why this is so. Is it related to a change in another commit?
* What the implications are of this change not being applied:
  the driver doesn't work?

> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 0c27c81..66ec616 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
>  		.start	= 0xe6a30000,
>  		.end	= 0xe6a3009b,
>  		.flags	= IORESOURCE_MEM,
> -	}
> +	},
> +	[1] = {
> +		.start	= evt2irq(0x0d80), /* flstei: status error irq */
> +		.flags	= IORESOURCE_IRQ,
> +	},
>  };
>  
>  static struct sh_flctl_platform_data nand_flash_data = {
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Bastian Hecht]

Hello Simon,

> could you provide a little more information on:
> * Why this is so. Is it related to a change in another commit?

Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd:
sh_flctl: Add support for error IRQ.
It notifies us when the actual communication from our flash controller
to the NAND chip fails.

> * What the implications are of this change not being applied:
>   the driver doesn't work?

Yes the driver refuses to start up if the error IRQ is missing.

Do you think I should include such information into the commit
message, or is it just helpful for the upstream process?

Cheers,

 Bastian

Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Simon Horman]

On Thu, Nov 15, 2012 at 10:13:51AM +0100, Bastian Hecht wrote:
> Hello Simon,
> 
> > could you provide a little more information on:
> > * Why this is so. Is it related to a change in another commit?
> 
> Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd:
> sh_flctl: Add support for error IRQ.
> It notifies us when the actual communication from our flash controller
> to the NAND chip fails.
> 
> > * What the implications are of this change not being applied:
> >   the driver doesn't work?
> 
> Yes the driver refuses to start up if the error IRQ is missing.
> 
> Do you think I should include such information into the commit
> message, or is it just helpful for the upstream process?

Yes. Please re-post the patch with a revised commit message
that includes the information above.

[PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Bastian Hecht]

Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
the sh_flctl driver requires the error IRQ line to signal failed
transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start
up. We provide it here for the board mackerel.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v1: extended commit
v2: added commit message of referenced patch

 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index 0c27c81..66ec616 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {
-- 
1.7.9.5

Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Simon Horman]

On Tue, Nov 20, 2012 at 01:05:00AM +0100, Bastian Hecht wrote:
> Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
> the sh_flctl driver requires the error IRQ line to signal failed
> transactions between the flash controller and the NAND chip.
> This information is mandatory - else the driver refuses to start
> up. We provide it here for the board mackerel.
> 
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
> ---
> v1: extended commit
> v2: added commit message of referenced patch

Thanks, I have updated the boards2 branch and sent an
updated pull-request to arm-soc.

[GIT PULL] Renesas ARM-based SoC boards for v3.8 #3

[Simon Horman]

Hi Olof, Hi Arnd,

Please consider the following board fix for 3.8.

Also, please let me know if you would prefer me to supply
this as a fixes branch as we are now in the 3.7-rc6 timeframe
where I understand that non-fix commits are no longer allowed for 3.8.

This commit is based on the renesas/boards2 branch of the arm-soc tree.

----------------------------------------------------------------
The following changes since commit 12818d82ccad9868a820dbb193b4f9b797cd02d4:

  ARM: shmobile: use FSI driver's audio clock on ap4evb (2012-11-08 17:52:05 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git boards3

for you to fetch changes up to d01f4b82fbee516b4d3f03b086333fc4a127983c:

  ARM: shmobile: mackerel: Add FLCTL IRQ resource (2012-11-19 10:08:20 +0900)

----------------------------------------------------------------
Bastian Hecht (1):
      ARM: shmobile: mackerel: Add FLCTL IRQ resource

 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Simon Horman]

From: Bastian Hecht <hechtb@gmail.com>

Since commit 3c7ea4eccfd2e the sh_flctl driver requires the error IRQ line to
signal failed transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start up. We
provide it here for the board mackerel.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@ static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {
-- 
1.7.10.4

Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Sergei Shtylyov]

Hello.

On 19-11-2012 5:24, Simon Horman wrote:

> From: Bastian Hecht <hechtb@gmail.com>

> Since commit 3c7ea4eccfd2e

    Please also specify that commit summary in parens.

> the sh_flctl driver requires the error IRQ line to
> signal failed transactions between the flash controller and the NAND chip.
> This information is mandatory - else the driver refuses to start up. We
> provide it here for the board mackerel.

> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>

WBR, Sergei

Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Simon Horman]

On Mon, Nov 19, 2012 at 04:30:59PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 19-11-2012 5:24, Simon Horman wrote:
> 
> >From: Bastian Hecht <hechtb@gmail.com>
> 
> >Since commit 3c7ea4eccfd2e
> 
>    Please also specify that commit summary in parens.

Thanks, I will fix this and re-post.

> >the sh_flctl driver requires the error IRQ line to
> >signal failed transactions between the flash controller and the NAND chip.
> >This information is mandatory - else the driver refuses to start up. We
> >provide it here for the board mackerel.
> 
> >Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> >Signed-off-by: Simon Horman <horms@verge.net.au>
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[GIT PULL v2] Renesas ARM-based SoC boards for v3.8 #3

[Simon Horman]

Hi Olof, Hi Arnd,

Please consider the following board fix for 3.8.

The commit message for the patch has been revised since yesterday's
pull-request.

Also, please let me know if you would prefer me to supply
this as a fixes branch as we are now in the 3.7-rc6 timeframe
where I understand that non-fix commits are no longer allowed for 3.8.

This commit is based on the renesas/boards2 branch of the arm-soc tree.

----------------------------------------------------------------
The following changes since commit 12818d82ccad9868a820dbb193b4f9b797cd02d4:

  ARM: shmobile: use FSI driver's audio clock on ap4evb (2012-11-08 17:52:05 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git boards3

for you to fetch changes up to 3042ac5731e6db441dfce85612da4aa3913dab3b:

  ARM: shmobile: mackerel: Add FLCTL IRQ resource (2012-11-20 09:14:43 +0900)

----------------------------------------------------------------
Bastian Hecht (1):
      ARM: shmobile: mackerel: Add FLCTL IRQ resource

 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource

[Simon Horman]

From: Bastian Hecht <hechtb@gmail.com>

Since commit 3c7ea4e (mtd: sh_flctl: Add support for error IRQ)
the sh_flctl driver requires the error IRQ line to signal failed
transactions between the flash controller and the NAND chip.
This information is mandatory - else the driver refuses to start
up. We provide it here for the board mackerel.

Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
index bf2bcb9..3f56e70 100644
--- a/arch/arm/mach-shmobile/board-mackerel.c
+++ b/arch/arm/mach-shmobile/board-mackerel.c
@@ -950,7 +950,11 @@ static struct resource nand_flash_resources[] = {
 		.start	= 0xe6a30000,
 		.end	= 0xe6a3009b,
 		.flags	= IORESOURCE_MEM,
-	}
+	},
+	[1] = {
+		.start	= evt2irq(0x0d80), /* flstei: status error irq */
+		.flags	= IORESOURCE_IRQ,
+	},
 };
 
 static struct sh_flctl_platform_data nand_flash_data = {
-- 
1.7.10.4