[PATCH v3 0/3] bockw SD pull-ups

[PATCH v3 0/3] bockw SD pull-ups

[Ulrich Hecht]

Hi!

This series implements pull-up configuration in the r8a7778 PFC driver
and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
replacing the hack that is used in the legacy platforms.

This version returns from the bias methods without doing any I/O if a pin
is undefined; thanks to Laurent for pointing this out.  It also includes
the various Acks.

CU
Uli


Changes since v2:
- return from get_bias/set_bias without doing I/O if a pin is undefined
- added Acks etc.

Changes since v1:
- use bitfields for pull-up table
- WARN_ON_ONCE instead of BUG_ON on undefined pull-ups


Ulrich Hecht (3):
  pinctrl: sh-pfc: add macros defining GP ports with config flags
  pinctrl: sh-pfc: r8a7778: Add bias (pull-up) pinconf support
  ARM: shmobile: bockw dts: define sdhi0 pins with pull-ups

 arch/arm/boot/dts/r8a7778-bockw.dts  |  10 +-
 drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 263 ++++++++++++++++++++++++++++++++---
 drivers/pinctrl/sh-pfc/sh_pfc.h      |  47 ++++---
 3 files changed, 274 insertions(+), 46 deletions(-)

-- 
2.6.0

Re: [PATCH v3 0/3] bockw SD pull-ups

[Linus Walleij]

On Mon, Oct 5, 2015 at 4:55 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:

> This series implements pull-up configuration in the r8a7778 PFC driver
> and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
> replacing the hack that is used in the legacy platforms.
>
> This version returns from the bias methods without doing any I/O if a pin
> is undefined; thanks to Laurent for pointing this out.  It also includes
> the various Acks.

For all patches:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

I'm expecting Geert to accumulate this and send a pull request to me.

Yours,
Linus Walleij

Re: [PATCH v3 0/3] bockw SD pull-ups

[Geert Uytterhoeven]

Hi Linus,

On Fri, Oct 16, 2015 at 4:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Oct 5, 2015 at 4:55 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
>
>> This series implements pull-up configuration in the r8a7778 PFC driver
>> and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
>> replacing the hack that is used in the legacy platforms.
>>
>> This version returns from the bias methods without doing any I/O if a pin
>> is undefined; thanks to Laurent for pointing this out.  It also includes
>> the various Acks.
>
> For all patches:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks!

> I'm expecting Geert to accumulate this and send a pull request to me.

Will do next week.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds