From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greentime Hu <green.hu@gmail.com>
Date: Thu, 26 Apr 2018 08:06:34 +0000
Subject: Re: [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Message-Id: <CAEbi=3e3gM_WpQOtKZXP4Xj2Az4bLf_u6BjDELqXy6-d9HurMQ@mail.gmail.com>
List-Id: <linux-sh.vger.kernel.org>
References: <20180420080313.18796-1-hch@lst.de> <20180420080313.18796-14-hch@lst.de>
 <CAEbi=3fkakVD2vxGu6SgJM77JnNM8Y79xS8_o6m9d_85BJpMFQ@mail.gmail.com>
 <20180424191640.GA32495@lst.de> <CAEbi=3f7yzE+KAM2GOh6QahC_E6BAUfB3ys3U-WdBSUf3DPZqg@mail.gmail.com>
 <20180425064055.GA11460@lst.de> <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com>
 <20180426064239.GA13895@lst.de>
In-Reply-To: <20180426064239.GA13895@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>, Michal Simek <monstr@monstr.eu>, Vincent Chen <deanbo422@gmail.com>, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux <sparclinux@vger.kernel.org>, linux-xtensa@linux-xtensa.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>

2018-04-26 14:42 GMT+08:00 Christoph Hellwig <hch@lst.de>:
> Can you try this patch ontop of either the new or original one?
>
> ---
> diff --git a/lib/dma-noncoherent.c b/lib/dma-noncoherent.c
> index f4b8532c20ac..a2c192b3508d 100644
> --- a/lib/dma-noncoherent.c
> +++ b/lib/dma-noncoherent.c
> @@ -48,7 +48,7 @@ static int dma_noncoherent_map_sg(struct device *dev, struct scatterlist *sgl,
>         return nents;
>  }
>
> -#ifdef CONFIG_DMA_NONCOHERENT_SYNC_FOR_CPU
> +#ifdef CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU
>  static void dma_noncoherent_sync_single_for_cpu(struct device *dev,
>                 dma_addr_t addr, size_t size, enum dma_data_direction dir)
>  {
> @@ -88,7 +88,7 @@ const struct dma_map_ops dma_noncoherent_ops = {
>         .sync_sg_for_device     = dma_noncoherent_sync_sg_for_device,
>         .map_page               = dma_noncoherent_map_page,
>         .map_sg                 = dma_noncoherent_map_sg,
> -#ifdef CONFIG_DMA_NONCOHERENT_SYNC_FOR_CPU
> +#ifdef CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU
>         .sync_single_for_cpu    = dma_noncoherent_sync_single_for_cpu,
>         .sync_sg_for_cpu        = dma_noncoherent_sync_sg_for_cpu,
>         .unmap_page             = dma_noncoherent_unmap_page,

It works!!!