From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP clock to device tree
Date: Fri, 10 Oct 2014 02:46:35 +0000 [thread overview]
Message-ID: <CAH1o70J5OFBFBnNApfidFGeBY11+BRv6_pJNJer_DTMvOt=vyQ@mail.gmail.com> (raw)
In-Reply-To: <20141010012414.GG5856@verge.net.au>
2014-10-10 10:24 GMT+09:00 Simon Horman <horms@verge.net.au>:
> On Thu, Oct 09, 2014 at 02:29:53PM +0200, Geert Uytterhoeven wrote:
>> Hi Kaneko-san, Hosoya-san,
>>
>> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> > From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>
>> Thanks for your patches!
>>
>> > Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> > ---
>> > arch/arm/boot/dts/r8a7790.dtsi | 22 ++++++++++++++--------
>> > include/dt-bindings/clock/r8a7790-clock.h | 11 ++++++++++-
>> > 2 files changed, 24 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> > index 27c038c..244a838 100644
>> > --- a/arch/arm/boot/dts/r8a7790.dtsi
>> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>
>> > clock-output-names >> > - "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0",
>> > + "vcp1", "vcp0", "vpc1", "vpc0", "jpu", "ssp1",
>> > + "tmu1", "pvrsrvkm", "2ddmac", "fdp2", "fdp1",
>> > + "fdp0", "tmu3", "tmu2", "cmt0", "tmu0",
>>
>> The datasheet calls these clocks "fdp1-2", "fdp1-1", and "fdp1-0", instead
>> of "fdp2", "fdp1", and "fdp0".
>
> Thanks.
>
> Kaneko-san, can you update the patches accordingly?
Sure, I will do it.
>
>> > --- a/include/dt-bindings/clock/r8a7790-clock.h
>> > +++ b/include/dt-bindings/clock/r8a7790-clock.h
>>
>> > +#define R8A7790_CLK_2DDMAC 15
>> > +#define R8A7790_CLK_FDP2 17
>> > +#define R8A7790_CLK_FDP1 18
>> > +#define R8A7790_CLK_FDP0 19
>> > #define R8A7790_CLK_TMU3 21
>> > #define R8A7790_CLK_TMU2 22
>> > #define R8A7790_CLK_CMT0 24
>>
>> Likewise.
>>
>> My comments also apply to the corresponding patch for r8a7791.
>>
>> Gr{oetje,eeting}s,
>>
>> Geert
>>
>> --
>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>>
>> In personal conversations with technical people, I call myself a hacker. But
>> when I'm talking to journalists I just say "programmer" or something like that.
>> -- Linus Torvalds
>>
next prev parent reply other threads:[~2014-10-10 2:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 10:03 [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
2014-10-09 12:27 ` Geert Uytterhoeven
2014-10-10 1:26 ` Simon Horman
2014-10-20 0:53 ` Magnus Damm
2014-10-21 16:02 ` Simon Horman
2014-10-22 9:31 ` Kouei Abe
2014-10-09 10:03 ` [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX " Yoshihiro Kaneko
2014-10-09 10:03 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
2014-10-09 12:29 ` Geert Uytterhoeven
2014-10-10 1:24 ` Simon Horman
2014-10-10 2:46 ` Yoshihiro Kaneko [this message]
2014-10-09 10:03 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 0/4] ARM: shmobile: Add clock to DT Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 1/4] ARM: shmobile: r8a7790: Add RGX clock to device tree Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 2/4] ARM: shmobile: r8a7791: Add SGX " Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 3/4] ARM: shmobile: r8a7790: Add MMP " Yoshihiro Kaneko
2014-10-14 7:01 ` [PATCH 4/4] ARM: shmobile: r8a7791: " Yoshihiro Kaneko
2014-10-14 19:30 ` [PATCH 0/4] ARM: shmobile: Add clock to DT Geert Uytterhoeven
2014-10-16 5:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH1o70J5OFBFBnNApfidFGeBY11+BRv6_pJNJer_DTMvOt=vyQ@mail.gmail.com' \
--to=ykaneko0929@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).