From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 20 Nov 2015 07:46:56 +0000 Subject: Re: [PATCH 17/25] serial: sh-sci: Correct SCIF type on R-Car for BRG Message-Id: List-Id: References: <1447958344-836-1-git-send-email-geert+renesas@glider.be> <1447958344-836-18-git-send-email-geert+renesas@glider.be> <1764695.P2DCFfYC1V@avalon> In-Reply-To: <1764695.P2DCFfYC1V@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Simon Horman , Magnus Damm , Yoshinori Sato , Laurent Pinchart , "linux-serial@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Hi Laurent, On Thu, Nov 19, 2015 at 9:55 PM, Laurent Pinchart wrote: > On Thursday 19 November 2015 19:38:56 Geert Uytterhoeven wrote: >> The "renesas,scif" compatible value is currently used for the SCIF >> variant in all Renesas SoCs of the R-Car family. However, the variant >> used in the R-Car family is not the common "SH-4(A)" variant, but a >> derivative with added "Baud Rate Generator for External Clock" (BRG), >> which is also present in sh7734. > > Time to introduce a "renesas,scif-rcar" compatible string ? ;-) > > As the only DT-enabled platform to have a different SCIF type is r7s72100 we > could also consider just switching the regtype to SCIx_SH4_SCIF_BRG_REGTYPE > for the generic "renesas,scif" entry as it's listed after the "renesas,scif- > r7s72100" entry. That might cause an issue if we want to enable DT on arch/sh > though, but even if that happens due to the J-Core processors I'd be surprised > to see the old Renesas SH platforms being moved to DT. I thought about that, but you never know in which out-of-tree BSP it ended up being used, too. So better safe than sorry. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds