From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 03/03] ARM: shmobile: Get rid of redundant EMEV2 mach callbacks
Date: Thu, 05 Jun 2014 08:13:56 +0000 [thread overview]
Message-ID: <CAMuHMdU=B7K2nWx281zK7w6K7cPRFFaWtkrDKMza8pUQLkhUUQ@mail.gmail.com> (raw)
In-Reply-To: <20140213082628.30630.3186.sendpatchset@w520>
Hi Magnus,
On Thu, Jun 5, 2014 at 7:32 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> --- 0003/arch/arm/mach-shmobile/setup-emev2.c
> +++ work/arch/arm/mach-shmobile/setup-emev2.c 2014-05-29 17:15:54.000000000 +0900
> @@ -16,10 +16,9 @@
> * along with this program; if not, write to the Free Software
> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> */
> -#include <linux/clk-provider.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> -#include <linux/of_platform.h>
> +#include <linux/mm.h>
Why is <linux/mm.h> needed?
Ah, arch/arm/mach-shmobile/include/mach/common.h lacks a forward
declaration of "struct task_struct;".
And then you still need to add "#include <asm/page.h>" for PAGE_SHIFT,
as <asm/memory.h> uses that in __phys_to_pfn().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-06-05 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 8:25 [PATCH 00/03] ARM: shmobile: Clean up the EMEV2 and KZM9D code base Magnus Damm
2014-02-13 8:26 ` [PATCH 01/03] ARM: shmobile: Remove legacy EMEV2 SoC support Magnus Damm
2014-02-17 3:23 ` Simon Horman
2014-02-18 4:16 ` Simon Horman
2014-02-18 4:25 ` Magnus Damm
2014-03-07 2:38 ` Simon Horman
2014-02-13 8:26 ` [PATCH 02/03] ARM: shmobile: Remove KZM9D board code Magnus Damm
2014-02-17 0:02 ` Simon Horman
2014-02-17 1:36 ` Magnus Damm
2014-02-17 1:44 ` Simon Horman
2014-02-13 8:26 ` [PATCH 03/03] ARM: shmobile: Get rid of legacy KZM9D defconfig Magnus Damm
2014-02-17 3:23 ` Simon Horman
2014-06-05 5:32 ` [PATCH 03/03] ARM: shmobile: Get rid of redundant EMEV2 mach callbacks Magnus Damm
2014-06-05 8:13 ` Geert Uytterhoeven [this message]
2014-06-05 21:40 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdU=B7K2nWx281zK7w6K7cPRFFaWtkrDKMza8pUQLkhUUQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).