* [PATCH v2 0/2] ARM: shmobile: r8a7791: add for USB-DMAC @ 2015-04-07 7:53 Yoshihiro Shimoda 2015-04-07 7:53 ` [PATCH v2 1/2] ARM: shmobile: r8a7791: add USB-DMAC device nodes Yoshihiro Shimoda 2015-04-07 7:53 ` [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB Yoshihiro Shimoda 0 siblings, 2 replies; 8+ messages in thread From: Yoshihiro Shimoda @ 2015-04-07 7:53 UTC (permalink / raw) To: horms, magnus.damm, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux Cc: devicetree, linux-arm-kernel, linux-sh, Yoshihiro Shimoda This patch set is based on renesas.git / renesas-devel-20150406-v4.0-rc6 tag. (commit id = 8acf8f0880b6a142e6291b9a7d81f2f38c9425ac) This patch set is related to the usb-dmac driver and renesas_usbhs driver. And these drivers have been merged in each subsystem: [ slave-dma repository ] https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/commit/?h=for-linus&id§267831565030ab94dab76eb1afe5d4b63a1009 https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/commit/?h=for-linus&id\f1c8ff32fa29e425b4938934c21afdb81104431 [ usb repository ] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&idz96b78464bd8ba72c1c3095c543c1402db59e35 https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id›53d9af7aac09cf249d72bfbf15f08e47c4f7fe https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id«330cf3888d8e0779fa05a243d53ba9f53a7ba9 Changes from v1: - Rebase the latest renesas-devel tag. Yoshihiro Shimoda (2): ARM: shmobile: r8a7791: add USB-DMAC device nodes ARM: shmobile: r8a7791: Enable DMA for HSUSB arch/arm/boot/dts/r8a7791.dtsi | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] ARM: shmobile: r8a7791: add USB-DMAC device nodes 2015-04-07 7:53 [PATCH v2 0/2] ARM: shmobile: r8a7791: add for USB-DMAC Yoshihiro Shimoda @ 2015-04-07 7:53 ` Yoshihiro Shimoda [not found] ` <1428393231-5272-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2015-04-07 7:53 ` [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB Yoshihiro Shimoda 1 sibling, 1 reply; 8+ messages in thread From: Yoshihiro Shimoda @ 2015-04-07 7:53 UTC (permalink / raw) To: horms, magnus.damm, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux Cc: devicetree, linux-arm-kernel, linux-sh, Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- arch/arm/boot/dts/r8a7791.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index 3e9f824..db3772e 100644 --- a/arch/arm/boot/dts/r8a7791.dtsi +++ b/arch/arm/boot/dts/r8a7791.dtsi @@ -357,6 +357,28 @@ dma-channels = <13>; }; + usb_dmac0: dma-controller@e65a0000 { + compatible = "renesas,usb-dmac"; + reg = <0 0xe65a0000 0 0x100>; + interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH + 0 109 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch0", "ch1"; + clocks = <&mstp3_clks R8A7791_CLK_USBDMAC0>; + #dma-cells = <1>; + dma-channels = <2>; + }; + + usb_dmac1: dma-controller@e65b0000 { + compatible = "renesas,usb-dmac"; + reg = <0 0xe65b0000 0 0x100>; + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH + 0 110 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ch0", "ch1"; + clocks = <&mstp3_clks R8A7791_CLK_USBDMAC1>; + #dma-cells = <1>; + dma-channels = <2>; + }; + /* The memory map in the User's Manual maps the cores to bus numbers */ i2c0: i2c@e6508000 { #address-cells = <1>; -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <1428393231-5272-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v2 1/2] ARM: shmobile: r8a7791: add USB-DMAC device nodes [not found] ` <1428393231-5272-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> @ 2015-04-07 13:25 ` Geert Uytterhoeven 0 siblings, 0 replies; 8+ messages in thread From: Geert Uytterhoeven @ 2015-04-07 13:25 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Simon Horman, Magnus Damm, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA, Linux-sh list On Tue, Apr 7, 2015 at 9:53 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB 2015-04-07 7:53 [PATCH v2 0/2] ARM: shmobile: r8a7791: add for USB-DMAC Yoshihiro Shimoda 2015-04-07 7:53 ` [PATCH v2 1/2] ARM: shmobile: r8a7791: add USB-DMAC device nodes Yoshihiro Shimoda @ 2015-04-07 7:53 ` Yoshihiro Shimoda [not found] ` <1428393231-5272-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 1 sibling, 1 reply; 8+ messages in thread From: Yoshihiro Shimoda @ 2015-04-07 7:53 UTC (permalink / raw) To: horms, magnus.damm, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux Cc: devicetree, linux-arm-kernel, linux-sh, Yoshihiro Shimoda This patch adds DMA properties to the HSUSB node. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- arch/arm/boot/dts/r8a7791.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index db3772e..5f20ad4 100644 --- a/arch/arm/boot/dts/r8a7791.dtsi +++ b/arch/arm/boot/dts/r8a7791.dtsi @@ -722,6 +722,9 @@ renesas,buswait = <4>; phys = <&usb0 1>; phy-names = "usb"; + dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, + <&usb_dmac1 0>, <&usb_dmac1 1>; + dma-names = "rx0", "tx1", "rx2", "tx3"; status = "disabled"; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <1428393231-5272-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB [not found] ` <1428393231-5272-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> @ 2015-04-07 13:34 ` Geert Uytterhoeven 2015-04-08 2:20 ` Yoshihiro Shimoda 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2015-04-07 13:34 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Simon Horman, Magnus Damm, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA, Linux-sh list Hi Shimoda-san, On Tue, Apr 7, 2015 at 9:53 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > This patch adds DMA properties to the HSUSB node. Thank you for your patch! > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > arch/arm/boot/dts/r8a7791.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi > index db3772e..5f20ad4 100644 > --- a/arch/arm/boot/dts/r8a7791.dtsi > +++ b/arch/arm/boot/dts/r8a7791.dtsi > @@ -722,6 +722,9 @@ > renesas,buswait = <4>; > phys = <&usb0 1>; > phy-names = "usb"; > + dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, > + <&usb_dmac1 0>, <&usb_dmac1 1>; > + dma-names = "rx0", "tx1", "rx2", "tx3"; The numbering looks a bit strange, given the code looks up both tx and rx DMA channels for each channel index. Is it correct? The binding documentation (which lacks on example) states: - dma-names : Must contain a list of DMA names: - tx0 ... tx<n> - rx0 ... rx<n> - This <n> means DnFIFO in USBHS module. As there are 4 DnFIFOs, I'd expect tx0..tx3 and rx0..rx3. Can you please clarify? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB 2015-04-07 13:34 ` Geert Uytterhoeven @ 2015-04-08 2:20 ` Yoshihiro Shimoda 2015-04-08 7:43 ` Geert Uytterhoeven 0 siblings, 1 reply; 8+ messages in thread From: Yoshihiro Shimoda @ 2015-04-08 2:20 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Simon Horman, Magnus Damm, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree@vger.kernel.org, linux-arm-kernel@vger.kernel.org, Linux-sh list SGkgR2VlcnQtc2FuLA0KDQo+IEhpIFNoaW1vZGEtc2FuLA0KPiANCj4gT24gVHVlLCBBcHIgNywg MjAxNSBhdCA5OjUzIEFNLCBZb3NoaWhpcm8gU2hpbW9kYQ0KPiA8eW9zaGloaXJvLnNoaW1vZGEu dWhAcmVuZXNhcy5jb20+IHdyb3RlOg0KPiA+IFRoaXMgcGF0Y2ggYWRkcyBETUEgcHJvcGVydGll cyB0byB0aGUgSFNVU0Igbm9kZS4NCj4gDQo+IFRoYW5rIHlvdSBmb3IgeW91ciBwYXRjaCENCg0K VGhhbmsgeW91IGZvciB5b3VyIHJldmlldyENCg0KPiA+IFNpZ25lZC1vZmYtYnk6IFlvc2hpaGly byBTaGltb2RhIDx5b3NoaWhpcm8uc2hpbW9kYS51aEByZW5lc2FzLmNvbT4NCj4gPiAtLS0NCj4g PiAgYXJjaC9hcm0vYm9vdC9kdHMvcjhhNzc5MS5kdHNpIHwgMyArKysNCj4gPiAgMSBmaWxlIGNo YW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jv b3QvZHRzL3I4YTc3OTEuZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL3I4YTc3OTEuZHRzaQ0KPiA+ IGluZGV4IGRiMzc3MmUuLjVmMjBhZDQgMTAwNjQ0DQo+ID4gLS0tIGEvYXJjaC9hcm0vYm9vdC9k dHMvcjhhNzc5MS5kdHNpDQo+ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvcjhhNzc5MS5kdHNp DQo+ID4gQEAgLTcyMiw2ICs3MjIsOSBAQA0KPiA+ICAgICAgICAgICAgICAgICByZW5lc2FzLGJ1 c3dhaXQgPSA8ND47DQo+ID4gICAgICAgICAgICAgICAgIHBoeXMgPSA8JnVzYjAgMT47DQo+ID4g ICAgICAgICAgICAgICAgIHBoeS1uYW1lcyA9ICJ1c2IiOw0KPiA+ICsgICAgICAgICAgICAgICBk bWFzID0gPCZ1c2JfZG1hYzAgMD4sIDwmdXNiX2RtYWMwIDE+LA0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgPCZ1c2JfZG1hYzEgMD4sIDwmdXNiX2RtYWMxIDE+Ow0KPiA+ICsgICAgICAgICAg ICAgICBkbWEtbmFtZXMgPSAicngwIiwgInR4MSIsICJyeDIiLCAidHgzIjsNCj4gDQo+IFRoZSBu dW1iZXJpbmcgbG9va3MgYSBiaXQgc3RyYW5nZSwgZ2l2ZW4gdGhlIGNvZGUgbG9va3MgdXAgYm90 aCB0eCBhbmQgcngNCj4gRE1BIGNoYW5uZWxzIGZvciBlYWNoIGNoYW5uZWwgaW5kZXguIElzIGl0 IGNvcnJlY3Q/DQo+IA0KPiBUaGUgYmluZGluZyBkb2N1bWVudGF0aW9uICh3aGljaCBsYWNrcyBv biBleGFtcGxlKSBzdGF0ZXM6DQo+IA0KPiAgIC0gZG1hLW5hbWVzIDogTXVzdCBjb250YWluIGEg bGlzdCBvZiBETUEgbmFtZXM6DQo+ICAgIC0gdHgwIC4uLiB0eDxuPg0KPiAgICAtIHJ4MCAuLi4g cng8bj4NCj4gICAgIC0gVGhpcyA8bj4gbWVhbnMgRG5GSUZPIGluIFVTQkhTIG1vZHVsZS4NCj4g DQo+IEFzIHRoZXJlIGFyZSA0IERuRklGT3MsIEknZCBleHBlY3QgdHgwLi50eDMgYW5kIHJ4MC4u cngzLg0KPiANCj4gQ2FuIHlvdSBwbGVhc2UgY2xhcmlmeT8NCg0KSSB3cm90ZSBzb21lIGluZm9y bWF0aW9uIGJlbG93Lg0KQnV0LCBzaW5jZSBpdCBpcyBjb21wbGV4IGhhcmR3YXJlLCBJIGRvbid0 IGtub3cgSSBjYW4gZXhwbGFpbiB0aGlzIGFzIHdlbGwuLi4NCg0KQXQgZmlyc3QsIFItQ2FyIEdl bjIgaGFzIDIgVVNCLURNQUNzIGFuZCA0IGNoYW5uZWxzOg0KIFVTQi1ETUFDIDA6IGNoMA0KIFVT Qi1ETUFDIDA6IGNoMQ0KIFVTQi1ETUFDIDE6IGNoMA0KIFVTQi1ETUFDIDE6IGNoMQ0KUmVtYXJr czogSSBkb24ndCBrbm93IHdoeSBidXQgcGVyZm9ybWFuY2Ugb2YgVVNCLURNQUMgMCBpcyBnb29k IHRoYW4gVVNCLURNQUMgMS4NCiAgICAgICAgICAoUGxlYXNlIHJlZmVyIHRvIHRoZSBUYWJsZSA2 NC4xIG9mIHRoZSBkYXRhc2hlZXQuKQ0KDQpTbywgSSB3cm90ZSBkbWFzIHBhcmFtZXRlciBpbiBo c3VzYiBhcyB0aGUgZm9sbG93aW5nOg0KDQo+ID4gKyAgICAgICAgICAgICAgIGRtYXMgPSA8JnVz Yl9kbWFjMCAwPiwgPCZ1c2JfZG1hYzAgMT4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICA8 JnVzYl9kbWFjMSAwPiwgPCZ1c2JfZG1hYzEgMT47DQoNCg0KQW5kLCBSLUNhciBHZW4yIGhhcyA0 IERuRklGT3MgaW4gSFNVU0IuIHRvIGF2b2lkIGNvbXBsZXggaGFuZGxpbmcgZm9yIERuRklGT3Ms DQp0aGUgcmVuZXNhc191c2JocyBkcml2ZXIgdXNlcyBlYWNoIERuRklGTyBhcyBUWCBvciBSWCBk aXJlY3Rpb24gKG5vdCBiaS1kaXJlY3Rpb24pLg0KU28sIEkgd3JvdGUgZG1hLW5hbWVzIHBhcmFt ZXRlciBhcyB0aGUgZm9sbG93aW5nOg0KDQo+ID4gKyAgICAgICAgICAgICAgIGRtYS1uYW1lcyA9 ICJyeDAiLCAidHgxIiwgInJ4MiIsICJ0eDMiOw0KDQotIEQwRklGTyBhcyBSWCAoQWxzbyBpdCBp cyBjb25uZWN0ZWQgdG8gVVNCLURNQUMgMDogY2gwKQ0KLSBEMUZJRk8gYXMgVFggKEFsc28gaXQg aXMgY29ubmVjdGVkIHRvIFVTQi1ETUFDIDA6IGNoMSkNCi0gRDJGSUZPIGFzIFJYIChBbHNvIGl0 IGlzIGNvbm5lY3RlZCB0byBVU0ItRE1BQyAxOiBjaDApDQotIEQzRklGTyBhcyBUWCAoQWxzbyBp dCBpcyBjb25uZWN0ZWQgdG8gVVNCLURNQUMgMTogY2gxKQ0KDQpCZXN0IHJlZ2FyZHMsDQpZb3No aWhpcm8gU2hpbW9kYQ0KDQo+IFRoYW5rcyENCj4gDQo+IEdye29ldGplLGVldGluZ31zLA0KPiAN Cj4gICAgICAgICAgICAgICAgICAgICAgICAgR2VlcnQNCj4gDQo+IC0tDQo+IEdlZXJ0IFV5dHRl cmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGlu dXgtbTY4ay5vcmcNCj4gDQo+IEluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNobmlj YWwgcGVvcGxlLCBJIGNhbGwgbXlzZWxmIGEgaGFja2VyLiBCdXQNCj4gd2hlbiBJJ20gdGFsa2lu ZyB0byBqb3VybmFsaXN0cyBJIGp1c3Qgc2F5ICJwcm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlr ZSB0aGF0Lg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0tIExpbnVzIFRvcnZh bGRzDQo ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB 2015-04-08 2:20 ` Yoshihiro Shimoda @ 2015-04-08 7:43 ` Geert Uytterhoeven 2015-04-08 8:22 ` Yoshihiro Shimoda 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2015-04-08 7:43 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: Simon Horman, Magnus Damm, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree@vger.kernel.org, linux-arm-kernel@vger.kernel.org, Linux-sh list Hi Shimoda-san, On Wed, Apr 8, 2015 at 4:20 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: >> On Tue, Apr 7, 2015 at 9:53 AM, Yoshihiro Shimoda >> <yoshihiro.shimoda.uh@renesas.com> wrote: >> > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi >> > index db3772e..5f20ad4 100644 >> > --- a/arch/arm/boot/dts/r8a7791.dtsi >> > +++ b/arch/arm/boot/dts/r8a7791.dtsi >> > @@ -722,6 +722,9 @@ >> > renesas,buswait = <4>; >> > phys = <&usb0 1>; >> > phy-names = "usb"; >> > + dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, >> > + <&usb_dmac1 0>, <&usb_dmac1 1>; >> > + dma-names = "rx0", "tx1", "rx2", "tx3"; >> >> The numbering looks a bit strange, given the code looks up both tx and rx >> DMA channels for each channel index. Is it correct? >> >> The binding documentation (which lacks on example) states: >> >> - dma-names : Must contain a list of DMA names: >> - tx0 ... tx<n> >> - rx0 ... rx<n> >> - This <n> means DnFIFO in USBHS module. >> >> As there are 4 DnFIFOs, I'd expect tx0..tx3 and rx0..rx3. >> >> Can you please clarify? > > I wrote some information below. > But, since it is complex hardware, I don't know I can explain this as well... > > At first, R-Car Gen2 has 2 USB-DMACs and 4 channels: > USB-DMAC 0: ch0 > USB-DMAC 0: ch1 > USB-DMAC 1: ch0 > USB-DMAC 1: ch1 > Remarks: I don't know why but performance of USB-DMAC 0 is good than USB-DMAC 1. > (Please refer to the Table 64.1 of the datasheet.) > > So, I wrote dmas parameter in hsusb as the following: > >> > + dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, >> > + <&usb_dmac1 0>, <&usb_dmac1 1>; > > And, R-Car Gen2 has 4 DnFIFOs in HSUSB. to avoid complex handling for DnFIFOs, > the renesas_usbhs driver uses each DnFIFO as TX or RX direction (not bi-direction). > So, I wrote dma-names parameter as the following: > >> > + dma-names = "rx0", "tx1", "rx2", "tx3"; > > - D0FIFO as RX (Also it is connected to USB-DMAC 0: ch0) > - D1FIFO as TX (Also it is connected to USB-DMAC 0: ch1) > - D2FIFO as RX (Also it is connected to USB-DMAC 1: ch0) > - D3FIFO as TX (Also it is connected to USB-DMAC 1: ch1) Thanks for the explanation! Hence the "strange" numbering is a limitation of the driver, not of the hardware? In that case I think the DT should describe the hardware, not the driver limitation. As the FIFOs are bidirectional, there's just a one-to-one mapping of 4 DnFIFOs to 4 (2 channels x 2 DMACs) DMA channels. Which DnFIFO/channel is used for TX and which is used for RX is to be chosen by the driver, and can be fixed (e.g. use even channels for RX, odd for TX, like the current situation). What do you (and other people) think? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB 2015-04-08 7:43 ` Geert Uytterhoeven @ 2015-04-08 8:22 ` Yoshihiro Shimoda 0 siblings, 0 replies; 8+ messages in thread From: Yoshihiro Shimoda @ 2015-04-08 8:22 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Simon Horman, Magnus Damm, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree@vger.kernel.org, linux-arm-kernel@vger.kernel.org, Linux-sh list SGkgR2VlcnQtc2FuLA0KDQo+IEhpIFNoaW1vZGEtc2FuLA0KPiANCj4gT24gV2VkLCBBcHIgOCwg MjAxNSBhdCA0OjIwIEFNLCBZb3NoaWhpcm8gU2hpbW9kYQ0KPiA8eW9zaGloaXJvLnNoaW1vZGEu dWhAcmVuZXNhcy5jb20+IHdyb3RlOg0KPiA+PiBPbiBUdWUsIEFwciA3LCAyMDE1IGF0IDk6NTMg QU0sIFlvc2hpaGlybyBTaGltb2RhDQo+ID4+IDx5b3NoaWhpcm8uc2hpbW9kYS51aEByZW5lc2Fz LmNvbT4gd3JvdGU6DQo+ID4+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL3I4YTc3 OTEuZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL3I4YTc3OTEuZHRzaQ0KPiA+PiA+IGluZGV4IGRi Mzc3MmUuLjVmMjBhZDQgMTAwNjQ0DQo+ID4+ID4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvcjhh Nzc5MS5kdHNpDQo+ID4+ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvcjhhNzc5MS5kdHNpDQo+ ID4+ID4gQEAgLTcyMiw2ICs3MjIsOSBAQA0KPiA+PiA+ICAgICAgICAgICAgICAgICByZW5lc2Fz LGJ1c3dhaXQgPSA8ND47DQo+ID4+ID4gICAgICAgICAgICAgICAgIHBoeXMgPSA8JnVzYjAgMT47 DQo+ID4+ID4gICAgICAgICAgICAgICAgIHBoeS1uYW1lcyA9ICJ1c2IiOw0KPiA+PiA+ICsgICAg ICAgICAgICAgICBkbWFzID0gPCZ1c2JfZG1hYzAgMD4sIDwmdXNiX2RtYWMwIDE+LA0KPiA+PiA+ ICsgICAgICAgICAgICAgICAgICAgICAgPCZ1c2JfZG1hYzEgMD4sIDwmdXNiX2RtYWMxIDE+Ow0K PiA+PiA+ICsgICAgICAgICAgICAgICBkbWEtbmFtZXMgPSAicngwIiwgInR4MSIsICJyeDIiLCAi dHgzIjsNCj4gPj4NCj4gPj4gVGhlIG51bWJlcmluZyBsb29rcyBhIGJpdCBzdHJhbmdlLCBnaXZl biB0aGUgY29kZSBsb29rcyB1cCBib3RoIHR4IGFuZCByeA0KPiA+PiBETUEgY2hhbm5lbHMgZm9y IGVhY2ggY2hhbm5lbCBpbmRleC4gSXMgaXQgY29ycmVjdD8NCj4gPj4NCj4gPj4gVGhlIGJpbmRp bmcgZG9jdW1lbnRhdGlvbiAod2hpY2ggbGFja3Mgb24gZXhhbXBsZSkgc3RhdGVzOg0KPiA+Pg0K PiA+PiAgIC0gZG1hLW5hbWVzIDogTXVzdCBjb250YWluIGEgbGlzdCBvZiBETUEgbmFtZXM6DQo+ ID4+ICAgIC0gdHgwIC4uLiB0eDxuPg0KPiA+PiAgICAtIHJ4MCAuLi4gcng8bj4NCj4gPj4gICAg IC0gVGhpcyA8bj4gbWVhbnMgRG5GSUZPIGluIFVTQkhTIG1vZHVsZS4NCj4gPj4NCj4gPj4gQXMg dGhlcmUgYXJlIDQgRG5GSUZPcywgSSdkIGV4cGVjdCB0eDAuLnR4MyBhbmQgcngwLi5yeDMuDQo+ ID4+DQo+ID4+IENhbiB5b3UgcGxlYXNlIGNsYXJpZnk/DQo+ID4NCj4gPiBJIHdyb3RlIHNvbWUg aW5mb3JtYXRpb24gYmVsb3cuDQo+ID4gQnV0LCBzaW5jZSBpdCBpcyBjb21wbGV4IGhhcmR3YXJl LCBJIGRvbid0IGtub3cgSSBjYW4gZXhwbGFpbiB0aGlzIGFzIHdlbGwuLi4NCj4gPg0KPiA+IEF0 IGZpcnN0LCBSLUNhciBHZW4yIGhhcyAyIFVTQi1ETUFDcyBhbmQgNCBjaGFubmVsczoNCj4gPiAg VVNCLURNQUMgMDogY2gwDQo+ID4gIFVTQi1ETUFDIDA6IGNoMQ0KPiA+ICBVU0ItRE1BQyAxOiBj aDANCj4gPiAgVVNCLURNQUMgMTogY2gxDQo+ID4gUmVtYXJrczogSSBkb24ndCBrbm93IHdoeSBi dXQgcGVyZm9ybWFuY2Ugb2YgVVNCLURNQUMgMCBpcyBnb29kIHRoYW4gVVNCLURNQUMgMS4NCj4g PiAgICAgICAgICAgKFBsZWFzZSByZWZlciB0byB0aGUgVGFibGUgNjQuMSBvZiB0aGUgZGF0YXNo ZWV0LikNCj4gPg0KPiA+IFNvLCBJIHdyb3RlIGRtYXMgcGFyYW1ldGVyIGluIGhzdXNiIGFzIHRo ZSBmb2xsb3dpbmc6DQo+ID4NCj4gPj4gPiArICAgICAgICAgICAgICAgZG1hcyA9IDwmdXNiX2Rt YWMwIDA+LCA8JnVzYl9kbWFjMCAxPiwNCj4gPj4gPiArICAgICAgICAgICAgICAgICAgICAgIDwm dXNiX2RtYWMxIDA+LCA8JnVzYl9kbWFjMSAxPjsNCj4gPg0KPiA+IEFuZCwgUi1DYXIgR2VuMiBo YXMgNCBEbkZJRk9zIGluIEhTVVNCLiB0byBhdm9pZCBjb21wbGV4IGhhbmRsaW5nIGZvciBEbkZJ Rk9zLA0KPiA+IHRoZSByZW5lc2FzX3VzYmhzIGRyaXZlciB1c2VzIGVhY2ggRG5GSUZPIGFzIFRY IG9yIFJYIGRpcmVjdGlvbiAobm90IGJpLWRpcmVjdGlvbikuDQo+ID4gU28sIEkgd3JvdGUgZG1h LW5hbWVzIHBhcmFtZXRlciBhcyB0aGUgZm9sbG93aW5nOg0KPiA+DQo+ID4+ID4gKyAgICAgICAg ICAgICAgIGRtYS1uYW1lcyA9ICJyeDAiLCAidHgxIiwgInJ4MiIsICJ0eDMiOw0KPiA+DQo+ID4g LSBEMEZJRk8gYXMgUlggKEFsc28gaXQgaXMgY29ubmVjdGVkIHRvIFVTQi1ETUFDIDA6IGNoMCkN Cj4gPiAtIEQxRklGTyBhcyBUWCAoQWxzbyBpdCBpcyBjb25uZWN0ZWQgdG8gVVNCLURNQUMgMDog Y2gxKQ0KPiA+IC0gRDJGSUZPIGFzIFJYIChBbHNvIGl0IGlzIGNvbm5lY3RlZCB0byBVU0ItRE1B QyAxOiBjaDApDQo+ID4gLSBEM0ZJRk8gYXMgVFggKEFsc28gaXQgaXMgY29ubmVjdGVkIHRvIFVT Qi1ETUFDIDE6IGNoMSkNCj4gDQo+IFRoYW5rcyBmb3IgdGhlIGV4cGxhbmF0aW9uIQ0KPiANCj4g SGVuY2UgdGhlICJzdHJhbmdlIiBudW1iZXJpbmcgaXMgYSBsaW1pdGF0aW9uIG9mIHRoZSBkcml2 ZXIsIG5vdCBvZiB0aGUNCj4gaGFyZHdhcmU/DQoNClRoYW5rIHlvdSBmb3IgdGhlIHBvaW50ISBU aGF0J3MgY29ycmVjdC4NCg0KPiBJbiB0aGF0IGNhc2UgSSB0aGluayB0aGUgRFQgc2hvdWxkIGRl c2NyaWJlIHRoZSBoYXJkd2FyZSwgbm90IHRoZSBkcml2ZXINCj4gbGltaXRhdGlvbi4gQXMgdGhl IEZJRk9zIGFyZSBiaWRpcmVjdGlvbmFsLCB0aGVyZSdzIGp1c3QgYSBvbmUtdG8tb25lIG1hcHBp bmcNCj4gb2YgNCBEbkZJRk9zIHRvIDQgKDIgY2hhbm5lbHMgeCAyIERNQUNzKSBETUEgY2hhbm5l bHMuDQoNCkkgdW5kZXJzdG9vZCBpdC4NCihTb21ldGltZXMgSSBmb3JnZXQgdGhhdCB0aGUgRFQg c2hvdWxkIGRlc2NyaWJlIHRoZSBoYXJkd2FyZS4uLikNCg0KPiBXaGljaCBEbkZJRk8vY2hhbm5l bCBpcyB1c2VkIGZvciBUWCBhbmQgd2hpY2ggaXMgdXNlZCBmb3IgUlggaXMgdG8gYmUgY2hvc2Vu DQo+IGJ5IHRoZSBkcml2ZXIsIGFuZCBjYW4gYmUgZml4ZWQgKGUuZy4gdXNlIGV2ZW4gY2hhbm5l bHMgZm9yIFJYLCBvZGQgZm9yDQo+IFRYLCBsaWtlIHRoZSBjdXJyZW50IHNpdHVhdGlvbikuDQo+ IA0KPiBXaGF0IGRvIHlvdSAoYW5kIG90aGVyIHBlb3BsZSkgdGhpbms/DQoNClRoYW5rIHlvdSBm b3IgdGhlIHN1Z2dlc3Rpb24hDQpJIHdpbGwgbW9kaWZ5IHRoZSByZW5lc2FzX3VzYmhzIGRyaXZl ci4NCkFsc28gSSB3b3VsZCBsaWtlIHRvIHJldmlzZSB0aGUgYmluZGluZyBkb2N1bWVudGF0aW9u IGFzIHRoZSBmb2xsb3dpbmc6DQoNCi0gZG1hLW5hbWVzIDogbmFtZWQgImNoJXUiLCB3aGVyZSAl dSBpcyB0aGUgY2hhbm5lbCBudW1iZXIgcmFuZ2luZyBmcm9tIHplcm8NCiAgICAgICAgICAgICAg dG8gdGhlIG51bWJlciBvZiBjaGFubmVscyAoRG5GSUZPcykgbWludXMgb25lLg0KDQpCZXN0IHJl Z2FyZHMsDQpZb3NoaWhpcm8gU2hpbW9kYQ0KDQo+IEdye29ldGplLGVldGluZ31zLA0KPiANCj4g ICAgICAgICAgICAgICAgICAgICAgICAgR2VlcnQNCj4gDQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhv ZXZlbiAtLSBUaGVyZSdzIGxvdHMgb2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgt bTY4ay5vcmcNCj4gDQo+IEluIHBlcnNvbmFsIGNvbnZlcnNhdGlvbnMgd2l0aCB0ZWNobmljYWwg cGVvcGxlLCBJIGNhbGwgbXlzZWxmIGEgaGFja2VyLiBCdXQNCj4gd2hlbiBJJ20gdGFsa2luZyB0 byBqb3VybmFsaXN0cyBJIGp1c3Qgc2F5ICJwcm9ncmFtbWVyIiBvciBzb21ldGhpbmcgbGlrZSB0 aGF0Lg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0tIExpbnVzIFRvcnZhbGRz DQo ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-04-08 8:22 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-07 7:53 [PATCH v2 0/2] ARM: shmobile: r8a7791: add for USB-DMAC Yoshihiro Shimoda 2015-04-07 7:53 ` [PATCH v2 1/2] ARM: shmobile: r8a7791: add USB-DMAC device nodes Yoshihiro Shimoda [not found] ` <1428393231-5272-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2015-04-07 13:25 ` Geert Uytterhoeven 2015-04-07 7:53 ` [PATCH v2 2/2] ARM: shmobile: r8a7791: Enable DMA for HSUSB Yoshihiro Shimoda [not found] ` <1428393231-5272-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2015-04-07 13:34 ` Geert Uytterhoeven 2015-04-08 2:20 ` Yoshihiro Shimoda 2015-04-08 7:43 ` Geert Uytterhoeven 2015-04-08 8:22 ` Yoshihiro Shimoda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).