From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 28 Jan 2019 09:21:44 +0000 Subject: Re: [PATCH 1/7] sh_eth: rename sh_eth_cpu_data::hw_checksum Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: netdev , "David S. Miller" , Linux-Renesas , Linux-sh list Hi Sergei, Thanks for your patch! On Sun, Jan 27, 2019 at 6:40 PM Sergei Shtylyov wrote: > Commit 62e04b7e0e3c ("sh_eth: rename 'sh_eth_cpu_data::hw_crc'") renamed > the field to 'hw_checksum' for the Ether DMAC "intelligent checksum", > however some Ether MACs implement a simpler checksumming scheme, so that > name now seems misleading. Rename that filed to 'csmr' as the "intelligent > checkmum" is always controlled by the CSMR register. checksum > Signed-off-by: Sergei Shtylyov Apart from that: Reviewed-by: Geert Uytterhoeven > --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c > +++ net-next/drivers/net/ethernet/renesas/sh_eth.c > @@ -793,7 +793,7 @@ static struct sh_eth_cpu_data r8a77980_d > .no_trimd = 1, > .no_ade = 1, > .xdfar_rw = 1, > - .hw_checksum = 1, > + .csmr = 1, Interestingly, I cannot find the CSMR register in the R-Car Gen3 docs? Not introduced by this patch, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds