From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Tue, 11 Mar 2014 10:58:01 +0000 Subject: Re: serial core: crash / race condition on unbind Message-Id: List-Id: References: <531E7F81.20400@hurleysoftware.com> In-Reply-To: <531E7F81.20400@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Hurley Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-sh list , One Thousand Gnomes Hi Peter, On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley wrote: >> >> [...] >> >> /* >> * Indicate that there isn't a port here anymore. >> */ >> uport->type = PORT_UNKNOWN; >> >> state->uart_port = NULL; > > How did this ever work? > > Detaching the ll driver from the tty port in this manner is not ok; > as you already note, it blows up if consoles are still running. No one unbinds serial drivers using serial_core, as all these drivers are for fixed hardware? Hot-pluggable usb-serial doesn't use serial_core. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds