From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 01/20] clk: shmobile: r8a7779: Add clocks support
Date: Sat, 01 Mar 2014 17:33:33 +0000 [thread overview]
Message-ID: <CAMuHMdV5DTrfY2u1mKA-9Dnjrn9PTDNZ6untMPM9qs7ruGwEKg@mail.gmail.com> (raw)
In-Reply-To: <20140301135002.GA4307@katana>
On Sat, Mar 1, 2014 at 2:50 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> --- a/include/linux/clk/shmobile.h
>> +++ b/include/linux/clk/shmobile.h
>> @@ -1,7 +1,9 @@
>> /*
>> * Copyright 2013 Ideas On Board SPRL
>> + * Copyright 2013 Horms Solutions Ltd.
>> *
>> * Contact: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> + * Contact: Simon Horman <horms@verge.net.au>
>> *
>> * This program is free software; you can redistribute it and/or modify
>> * it under the terms of the GNU General Public License as published by
>> @@ -14,6 +16,7 @@
>>
>> #include <linux/types.h>
>>
>> +void r8a7779_clocks_init(u32 mode);
>> void rcar_gen2_clocks_init(u32 mode);
>
> Shouldn't the init functions be protected by #ifdef CONFIG_ARCH...?
Not in header files.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-03-01 17:33 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 7:33 [PATCH v3 00/20] ARM: shmobile: r8a7779, marzen: CCF and multiplatform Simon Horman
2014-02-26 7:33 ` [PATCH v3 01/20] clk: shmobile: r8a7779: Add clocks support Simon Horman
2014-02-26 8:05 ` Geert Uytterhoeven
2014-02-26 8:59 ` Simon Horman
2014-02-26 9:06 ` Geert Uytterhoeven
2014-02-28 1:35 ` Simon Horman
2014-02-26 12:53 ` Laurent Pinchart
2014-02-26 13:02 ` Laurent Pinchart
2014-03-12 7:55 ` Simon Horman
2014-03-12 10:12 ` Laurent Pinchart
2014-03-13 2:22 ` Simon Horman
2014-03-13 9:07 ` Laurent Pinchart
2014-03-14 0:38 ` Simon Horman
2014-03-01 13:50 ` Wolfram Sang
2014-03-01 17:33 ` Geert Uytterhoeven [this message]
2014-03-02 11:35 ` Laurent Pinchart
2014-03-02 11:51 ` Geert Uytterhoeven
2014-03-02 11:59 ` Wolfram Sang
2014-02-26 7:33 ` [PATCH v3 02/20] clk: shmobile: r8a7779: Add MSTP clock support Simon Horman
2014-02-26 12:53 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 03/20] ARM: shmobile: r8a7779: Add clock index macros for DT sources Simon Horman
2014-02-26 12:56 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 04/20] ARM: shmobile: r8a7779: Add clocks Simon Horman
2014-02-26 8:13 ` Geert Uytterhoeven
2014-02-26 8:55 ` Simon Horman
2014-02-26 13:15 ` Laurent Pinchart
2014-03-12 8:40 ` Simon Horman
2014-02-26 14:45 ` Laurent Pinchart
2014-03-12 8:43 ` Simon Horman
2014-03-01 14:29 ` Wolfram Sang
2014-02-26 7:33 ` [PATCH v3 05/20] ARM: shmobile: Sync Marzen DTS with Marzen reference DTS Simon Horman
2014-02-26 13:17 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 06/20] ARM: shmobile: marzen: Specify external clock frequency in DT Simon Horman
2014-02-26 13:19 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 07/20] ARM: shmobile: marzen: Reference clocks Simon Horman
2014-02-26 13:20 ` Laurent Pinchart
2014-02-26 14:23 ` Sergei Shtylyov
2014-03-13 0:09 ` Simon Horman
2014-02-26 7:33 ` [PATCH v3 08/20] ARM: shmobile: r8a7779: " Simon Horman
2014-02-26 13:21 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 09/20] ARM: shmobile: r8a7779: Add helper to read mode pins Simon Horman
2014-02-26 7:33 ` [PATCH v3 10/20] ARM: shmobile: r8a7779: Move r8a7779_earlytimer_init to clock-r8a7779.c Simon Horman
2014-02-26 7:33 ` [PATCH v3 11/20] ARM: shmobile: marzen-reference: Move clock and OF device initialisation into board Simon Horman
2014-02-26 7:33 ` [PATCH v3 12/20] ARM: shmobile: r8a7779: Do not include sh_clk.h in r8a7779.h Simon Horman
2014-02-26 7:33 ` [PATCH v3 13/20] ARM: shmobile: r8a7779: Initial multiplatform support Simon Horman
2014-02-26 7:33 ` [PATCH v3 14/20] ARM: shmobile: marzen-reference: Initialize CPG device Simon Horman
2014-02-26 13:22 ` Laurent Pinchart
2014-02-26 7:33 ` [PATCH v3 15/20] ARM: shmobile: marzen-reference: Instantiate clkdevs for SCIF and TMU Simon Horman
2014-02-26 8:29 ` Geert Uytterhoeven
2014-02-26 8:56 ` Simon Horman
2014-02-26 13:24 ` Laurent Pinchart
2014-03-13 0:03 ` Simon Horman
2014-02-26 7:33 ` [PATCH v3 16/20] ARM: shmobile: marzen: Add to shmobile defconfig Simon Horman
2014-02-26 7:33 ` [PATCH v3 17/20] ARM: shmobile: Remove non-multiplatform Marzen reference support Simon Horman
2014-02-26 7:33 ` [PATCH v3 18/20] ARM: shmobile: Let Marzen multiplatform boot with Marzen DTB Simon Horman
2014-02-26 7:33 ` [PATCH v3 19/20] ARM: shmobile: Remove Marzen reference DTS Simon Horman
2014-02-26 7:33 ` [PATCH v3 20/20] ARM: shmobile: marzen-reference: Remove legacy clock support Simon Horman
2014-02-26 8:33 ` Geert Uytterhoeven
2014-02-26 8:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV5DTrfY2u1mKA-9Dnjrn9PTDNZ6untMPM9qs7ruGwEKg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).