From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: shmobile: r8a7790: add MSTP10 support on DTSI
Date: Tue, 10 Jun 2014 08:10:24 +0000 [thread overview]
Message-ID: <CAMuHMdVJ0MiD_RBJWDJNRY_qnZFoceP01d_B7DCYY1bq9oL+mg@mail.gmail.com> (raw)
In-Reply-To: <1383060193-1505-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Morimoto-san,
On Tue, Jun 10, 2014 at 9:48 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>> > + mstp10_clks: mstp10_clks@e6150998 {
>> > + compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
>> > + reg = <0 0xe6150998 0 4>, <0 0xe61509a8 0 4>;
>> > + clocks = <&p_clk>, /* parent of SCU */
>> > + <&p_clk>,
>> > + <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>> > + <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>> > + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
>> > + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
>> > + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
>> > + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
>> > + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
>> > + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>;
>> > +
>> > + #clock-cells = <1>;
>> > + clock-indices = <
>> > + R8A7790_CLK_SCU
>> > + R8A7790_CLK_SSI
>> > + R8A7790_CLK_SSI9 R8A7790_CLK_SSI8 R8A7790_CLK_SSI7 R8A7790_CLK_SSI6 R8A7790_CLK_SSI5
>> > + R8A7790_CLK_SSI4 R8A7790_CLK_SSI3 R8A7790_CLK_SSI2 R8A7790_CLK_SSI1 R8A7790_CLK_SSI0
>> > + R8A7790_CLK_DVC1 R8A7790_CLK_DVC0
>> > + R8A7790_CLK_SRC9 R8A7790_CLK_SRC8 R8A7790_CLK_SRC7 R8A7790_CLK_SRC6 R8A7790_CLK_SRC5
>> > + R8A7790_CLK_SRC4 R8A7790_CLK_SRC3 R8A7790_CLK_SRC2 R8A7790_CLK_SRC1 R8A7790_CLK_SRC0
>>
>> I think we usually put these in numerical order here.
>
> Do you mean R8A7790_CLK_SCU is out-of-order ?
I mean they should be in the same order as listed in
include/dt-bindings/clock/r8a7790-clock.h
> If so, Unfortunately, we need put "R8A7790_CLK_SCU" before "R8A7790_CLK_SRCx",
> because SCU(ALL) is parent clock of SRCn.
IC. I didn't look up the parent clock relations.
However, SCU_ALL = 17, while its children are 18-31, so numerical order
should be fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-06-10 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 15:23 [PATCH 0/3] ARM: shmobile: Lager reference serial port support Laurent Pinchart
2013-10-29 15:23 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add early debugging support Laurent Pinchart
2014-01-08 16:31 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add VIN clock support Valentine Barshak
2014-01-09 8:14 ` Simon Horman
2014-01-09 14:26 ` Valentine
2014-06-10 2:33 ` [PATCH 1/3] ARM: shmobile: r8a7790: add MSTP10 support on DTSI Kuninori Morimoto
2014-06-10 7:32 ` Geert Uytterhoeven
2014-06-10 7:35 ` Geert Uytterhoeven
2014-06-10 7:48 ` Kuninori Morimoto
2014-06-10 8:10 ` Geert Uytterhoeven [this message]
2014-06-10 8:23 ` Kuninori Morimoto
2015-01-27 9:13 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add IPMMU DT nodes Laurent Pinchart
2013-10-29 15:23 ` [PATCH 2/3] ARM: shmobile: r8a7790: Add serial ports to the device tree Laurent Pinchart
2013-10-29 15:23 ` [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT Laurent Pinchart
2013-10-29 18:09 ` Sergei Shtylyov
2013-10-29 18:30 ` Laurent Pinchart
2013-10-30 0:24 ` Simon Horman
2013-10-31 5:31 ` [PATCH 0/3] ARM: shmobile: Lager reference serial port support Simon Horman
2013-10-31 12:21 ` Laurent Pinchart
2013-11-01 0:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVJ0MiD_RBJWDJNRY_qnZFoceP01d_B7DCYY1bq9oL+mg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).