From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
Cc: thierry.bultel@linatsea.fr, linux-renesas-soc@vger.kernel.org,
paul.barker.ct@bp.renesas.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulrich Hecht <uli@fpond.eu>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v4 08/13] serial: sh-sci: Introduced function pointers
Date: Fri, 14 Mar 2025 12:05:54 +0100 [thread overview]
Message-ID: <CAMuHMdVM_ozW4LAA4DstQuDfEcOnOcXZ2QHGv8nYMKDPWJe43Q@mail.gmail.com> (raw)
In-Reply-To: <20250306152451.2356762-9-thierry.bultel.yh@bp.renesas.com>
Hi Thierry,
On Thu, 6 Mar 2025 at 16:26, Thierry Bultel
<thierry.bultel.yh@bp.renesas.com> wrote:
> The aim here is to prepare support for new sci controllers like
> the T2H/RSCI whose registers are too much different for being
> handled in common code.
>
> This named serial controller also has 32 bits register,
> so some return types had to be changed.
>
> The needed generic functions are no longer static, with prototypes
> defined in sh-sci-common.h so that they can be used from specific
> implementation in a separate file, to keep this driver as little
> changed as possible.
>
> For doing so, a set of 'ops' is added to struct sci_port.
>
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
> ---
> Changes v3->v4:
> - Add missing #include <bitfield.h>
> - Remove sci_poll_get_char sci_poll_put_char from sh-sci-common.h (both
> function are not used by rzsci yet).
> - Add missing #ifdef around .poll_put_char pointer initialization.
> - More registers to save & restore due to rebase on tty-next
Thanks for the update!
While most rough edges have been polished by now (thanks!), and the
driver seems to still work on a variety of platforms, I am still
worried about the impact of this change:
- Maintainability and future bug fixing?
- Performance of the additional indirections on slow platforms (SH)?
What do other people think?
Thanks!
Full series:
https://lore.kernel.org/all/20250306152451.2356762-1-thierry.bultel.yh@bp.renesas.com
My initial comments and RFC:
https://lore.kernel.org/all/CAMuHMdVD1dLP53V_zOhxpqazDdPDVafJ6iohY8u6WPQrmYH5Sw@mail.gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next parent reply other threads:[~2025-03-14 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250306152451.2356762-1-thierry.bultel.yh@bp.renesas.com>
[not found] ` <20250306152451.2356762-9-thierry.bultel.yh@bp.renesas.com>
2025-03-14 11:05 ` Geert Uytterhoeven [this message]
2025-03-17 9:55 ` [PATCH v4 08/13] serial: sh-sci: Introduced function pointers Wolfram Sang
2025-03-17 10:27 ` Paul Barker
2025-03-18 21:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVM_ozW4LAA4DstQuDfEcOnOcXZ2QHGv8nYMKDPWJe43Q@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=thierry.bultel@linatsea.fr \
--cc=uli@fpond.eu \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).