From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Thu, 08 May 2014 18:46:34 +0000 Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support Message-Id: List-Id: References: <1399494750-31996-1-git-send-email-geert+renesas@glider.be> <1399494750-31996-2-git-send-email-geert+renesas@glider.be> <536B7FD3.5090506@cogentembedded.com> <536B8340.4010901@cogentembedded.com> <536BC445.8080007@cogentembedded.com> In-Reply-To: <536BC445.8080007@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , Bastian Hecht , Linux-sh list , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Hi Sergei, On Thu, May 8, 2014 at 7:52 PM, Sergei Shtylyov wrote: >>>>>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */ > >>>>> This property is mandatory, according to the bindings. > >>>> Indeed, but you cannot put anything there until the platform has CCF, as >>>> mstp3_clks doesn't exist yet. > >>> Yes, that was the main obstacle to accepting those bindings sooner. >>> This patch therefore seems somewhat premature. > >> My main objective is to provide working Ethernet support for Armadillo >> reference now. > > Mine was the same (but for BOCK-W board) but DT people didn't give a > damn. :-) So there's still no Ethernet support in BOCK-W DT. Yes there is: ethernet@18300000. >> The DTS already has other nodes without "clocks" properties. > > It means not everybody submitting the bindings had the same bad luck as me. :-) I think we have to be pragmatic here. The clocks properties will be added to the dtsi as soon as we have CCF support. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds