Re: [PATCH 5/6] dmaengine: rcar-dmac: Add Renesas R-Car Gen2 DMA Controller (DMAC) driver

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Thu, Jul 31, 2014 at 2:34 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> +static struct dma_async_tx_descriptor *
> +rcar_dmac_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr,
> +                         size_t buf_len, size_t period_len,
> +                         enum dma_transfer_direction dir, unsigned long flags,
> +                         void *context)

BTW, the "context" parameter should be removed, as Laurent's independent
patch to remove it everywhere else has hit slave-dma/next"

drivers/dma/sh/rcar-dmac.c: In function 'rcar_dmac_probe':
drivers/dma/sh/rcar-dmac.c:1462:33: warning: assignment from
incompatible pointer type
  engine->device_prep_dma_cyclic = rcar_dmac_prep_dma_cyclic;
                                 ^
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds