From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Wed, 28 May 2014 08:42:05 +0000 Subject: Re: [PATCH v6 1/2] clk: shmobile: r8a7779: Add clocks support Message-Id: List-Id: References: <1397775951-30992-1-git-send-email-horms+renesas@verge.net.au> <1397775951-30992-2-git-send-email-horms+renesas@verge.net.au> <201405271131.42301.arnd@arndb.de> <20140528010850.GH7374@verge.net.au> In-Reply-To: <20140528010850.GH7374@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Simon, On Wed, May 28, 2014 at 3:08 AM, Simon Horman wrote: >> > +#include >> >> This currently causes a build error in Linux-next, since the header file >> has not been merged along with the driver. > > Hi Arnd, > > I'm a little unsure what combination of Kernel config options you > are using to compile this driver in linux-next but I do agree > that the header is missing and that would cause the compile to fail. > I apologise for that oversight. > > I believe that a good fix is to add the header, which I already have queued-up > in the renesas tree for v3.17. I wonder if Mike would consider taking > the following patch for v3.16. Alternatively I would be happy to send > it it to arm-soc as a fix for v3.16. IIUIC, the only reason the driver source needs the header file is: #define CPG_NUM_CLOCKS (R8A7779_CLK_OUT + 1) Why not #define CPG_NUM_CLOCKS 8 and drop the include? Or better, use "num_clks" (from of_property_count_strings(np, "clock-output-names")), like the other R-Car drivers do. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds