From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 06 Jan 2017 10:11:56 +0000 Subject: Re: [PATCH 04/19] sh: Don't set sh-sci pdata scscr TIE and RIE bits Message-Id: List-Id: References: <20170103230639.19660-1-laurent.pinchart+renesas@ideasonboard.com> <20170103230639.19660-5-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20170103230639.19660-5-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: Linux-Renesas , Linux-sh list , "linux-serial@vger.kernel.org" , Geert Uytterhoeven On Wed, Jan 4, 2017 at 12:06 AM, Laurent Pinchart wrote: > The scscr platform data field is used by the driver in three locations. > One of them masks out all bits except SCSCR_REIE. The two other are the > set_termios handler and the console write handler. > > The set_termios handler calls sci_start_rx() to enable the receiver, > which sets the RIE bit unconditionally. It then calls sci_port_disable() > that effectively disables both the transmitter and the receiver. The > TIE bit will thus get set later when the serial cores reenables the > serial port. > > The console write handler runs with interrupts disabled, and saves and > restores the SCSCR register value. The RIE and TIE bits are thus not > needed there. > > The bits are thus not necessary in platform data, remove them. > > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds