From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh@kernel.org>
Cc: Simon Horman <horms+renesas@verge.net.au>,
Vinod Koul <vinod.koul@intel.com>,
dmaengine@vger.kernel.org,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH] dmaengine: rcar-dmac: Document SoC specific bindings
Date: Fri, 13 Nov 2015 08:08:06 +0000 [thread overview]
Message-ID: <CAMuHMdWA6G+9YtGCnUx5iUUuC8HVJt9LPev82f5dCdCuVer9Fw@mail.gmail.com> (raw)
In-Reply-To: <20151112232805.GA5562@rob-hp-laptop>
Hi Rob,
On Fri, Nov 13, 2015 at 12:28 AM, Rob Herring <robh@kernel.org> wrote:
>> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
>> index 09daeef1ff22..5b902ac8d97e 100644
>> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
>> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
>> @@ -14,7 +14,14 @@ not described in these device tree bindings.
>>
>> Required Properties:
>>
>> -- compatible: must contain "renesas,rcar-dmac"
>> +- compatible: "renesas,dmac-<soctype>", "renesas,rcar-dmac" as fallback.
>
> Somehow Renesas has ended up being backwards from everyone else that
> does <vendor>,<chip>-<block>. Oh well...
I know. Renesas has a mix of both :-(
As in this case the generic one does follow the "<vendor>,<family>-<block>"
pattern ("renesas,rcar-dmac"), it may make sense to use
"renesas,<soctype>-dmac", to avoid having a mix in the bindings for the same
block.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2015-11-13 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 1:53 [PATCH] dmaengine: rcar-dmac: Document SoC specific bindings Simon Horman
2015-11-12 10:25 ` Geert Uytterhoeven
2015-11-12 23:28 ` Rob Herring
2015-11-13 8:08 ` Geert Uytterhoeven [this message]
2015-11-16 3:51 ` Vinod Koul
2016-01-14 10:09 ` Geert Uytterhoeven
2016-01-18 14:49 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWA6G+9YtGCnUx5iUUuC8HVJt9LPev82f5dCdCuVer9Fw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=horms+renesas@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).