From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: shmobile: r8a7790: add MSTP10 support on DTSI
Date: Tue, 10 Jun 2014 07:32:47 +0000 [thread overview]
Message-ID: <CAMuHMdWZd0W7MnZYAbgxeaWhqJ8e5uion5qbqsJhHE65w_=0tg@mail.gmail.com> (raw)
In-Reply-To: <1383060193-1505-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Morimoto-san,
On Tue, Jun 10, 2014 at 4:33 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -835,6 +835,38 @@
> "rcan1", "rcan0", "qspi_mod", "iic3",
> "i2c3", "i2c2", "i2c1", "i2c0";
> };
> + mstp10_clks: mstp10_clks@e6150998 {
> + compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
> + reg = <0 0xe6150998 0 4>, <0 0xe61509a8 0 4>;
> + clocks = <&p_clk>, /* parent of SCU */
> + <&p_clk>,
> + <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
> + <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
> + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
> + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
> + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
> + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
> + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>,
> + <&mstp10_clks R8A7790_CLK_SCU>, <&mstp10_clks R8A7790_CLK_SCU>;
> +
> + #clock-cells = <1>;
> + clock-indices = <
> + R8A7790_CLK_SCU
> + R8A7790_CLK_SSI
> + R8A7790_CLK_SSI9 R8A7790_CLK_SSI8 R8A7790_CLK_SSI7 R8A7790_CLK_SSI6 R8A7790_CLK_SSI5
> + R8A7790_CLK_SSI4 R8A7790_CLK_SSI3 R8A7790_CLK_SSI2 R8A7790_CLK_SSI1 R8A7790_CLK_SSI0
> + R8A7790_CLK_DVC1 R8A7790_CLK_DVC0
> + R8A7790_CLK_SRC9 R8A7790_CLK_SRC8 R8A7790_CLK_SRC7 R8A7790_CLK_SRC6 R8A7790_CLK_SRC5
> + R8A7790_CLK_SRC4 R8A7790_CLK_SRC3 R8A7790_CLK_SRC2 R8A7790_CLK_SRC1 R8A7790_CLK_SRC0
I think we usually put these in numerical order here.
> + >;
> + clock-output-names > + "scu", "ssi",
> + "ssi9", "ssi8", "ssi7", "ssi6", "ssi5",
> + "ssi4", "ssi3", "ssi2", "ssi1", "ssi0",
> + "dvc1", "dvc0",
> + "src9", "src8", "src7", "src6", "src5",
> + "src4", "src3", "src2", "src1", "src0";
> + };
> };
>
> qspi: spi@e6b10000 {
> diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h
> index 1118f7a..b4430b0 100644
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> @@ -107,4 +107,30 @@
> #define R8A7790_CLK_I2C1 30
> #define R8A7790_CLK_I2C0 31
>
> +/* MSTP10 */
> +#define R8A7790_CLK_SSI 5
Should this be called R8A7790_CLK_SSI_ALL?
> +#define R8A7790_CLK_SSI9 6
> +#define R8A7790_CLK_SSI8 7
> +#define R8A7790_CLK_SSI7 8
> +#define R8A7790_CLK_SSI6 9
> +#define R8A7790_CLK_SSI5 10
> +#define R8A7790_CLK_SSI4 11
> +#define R8A7790_CLK_SSI3 12
> +#define R8A7790_CLK_SSI2 13
> +#define R8A7790_CLK_SSI1 14
> +#define R8A7790_CLK_SSI0 15
> +#define R8A7790_CLK_SCU 17
Should this be called R8A7790_CLK_SCU_ALL?
> +#define R8A7790_CLK_DVC1 18
> +#define R8A7790_CLK_DVC0 19
"#define R8A7790_CLK_SCU_CTU1x_MIX1 20" and
"#define R8A7790_CLK_SCU_CTU0x_MIX0 21" are missing?
> +#define R8A7790_CLK_SRC9 22
> +#define R8A7790_CLK_SRC8 23
> +#define R8A7790_CLK_SRC7 24
> +#define R8A7790_CLK_SRC6 25
> +#define R8A7790_CLK_SRC5 26
> +#define R8A7790_CLK_SRC4 27
> +#define R8A7790_CLK_SRC3 28
> +#define R8A7790_CLK_SRC2 29
> +#define R8A7790_CLK_SRC1 30
> +#define R8A7790_CLK_SRC0 31
Should these be called R8A7790_CLK_SCU_SRC[0-9]?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-06-10 7:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 15:23 [PATCH 0/3] ARM: shmobile: Lager reference serial port support Laurent Pinchart
2013-10-29 15:23 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add early debugging support Laurent Pinchart
2014-01-08 16:31 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add VIN clock support Valentine Barshak
2014-01-09 8:14 ` Simon Horman
2014-01-09 14:26 ` Valentine
2014-06-10 2:33 ` [PATCH 1/3] ARM: shmobile: r8a7790: add MSTP10 support on DTSI Kuninori Morimoto
2014-06-10 7:32 ` Geert Uytterhoeven [this message]
2014-06-10 7:35 ` Geert Uytterhoeven
2014-06-10 7:48 ` Kuninori Morimoto
2014-06-10 8:10 ` Geert Uytterhoeven
2014-06-10 8:23 ` Kuninori Morimoto
2015-01-27 9:13 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add IPMMU DT nodes Laurent Pinchart
2013-10-29 15:23 ` [PATCH 2/3] ARM: shmobile: r8a7790: Add serial ports to the device tree Laurent Pinchart
2013-10-29 15:23 ` [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT Laurent Pinchart
2013-10-29 18:09 ` Sergei Shtylyov
2013-10-29 18:30 ` Laurent Pinchart
2013-10-30 0:24 ` Simon Horman
2013-10-31 5:31 ` [PATCH 0/3] ARM: shmobile: Lager reference serial port support Simon Horman
2013-10-31 12:21 ` Laurent Pinchart
2013-11-01 0:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWZd0W7MnZYAbgxeaWhqJ8e5uion5qbqsJhHE65w_=0tg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).