From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Mon, 05 Jan 2015 13:38:35 +0000 Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7790: add CAN DT support Message-Id: List-Id: References: <2616635.bsb7mLynhA@wasted.cogentembedded.com> <5498306.nhRks3sT7k@wasted.cogentembedded.com> In-Reply-To: <5498306.nhRks3sT7k@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Mon, Dec 29, 2014 at 11:06 PM, Sergei Shtylyov wrote: > Define the generic R8A7790 parts of the CAN0/1 device nodes. > > Signed-off-by: Sergei Shtylyov Apart from the minor nit below Acked-by: Geert Uytterhoeven > --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi > +++ renesas/arch/arm/boot/dts/r8a7790.dtsi > @@ -792,6 +792,26 @@ > }; > }; > > + can0: can@e6e80000 { > + compatible = "renesas,can-r8a7790"; > + reg = <0 0xe6e80000 0 0x1000>; > + interrupts = <0 186 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp9_clks R8A7790_CLK_RCAN0>, > + <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; .git/rebase-apply/patch:18: space before tab in indent. <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; > + clock-names = "clkp1", "clkp2", "can_clk"; > + status = "disabled"; > + }; > + > + can1: can@e6e88000 { > + compatible = "renesas,can-r8a7790"; > + reg = <0 0xe6e88000 0 0x1000>; > + interrupts = <0 187 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp9_clks R8A7790_CLK_RCAN1>, > + <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; .git/rebase-apply/patch:28: space before tab in indent. <&cpg_clocks R8A7790_CLK_RCAN>, <&can_clk>; > + clock-names = "clkp1", "clkp2", "can_clk"; > + status = "disabled"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds