From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
Date: Sat, 15 Sep 2012 07:32:10 +0000 [thread overview]
Message-ID: <CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com> (raw)
In-Reply-To: <1347655456-2542-2-git-send-email-thierry.reding@avionic-design.de>
On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> --- a/drivers/pci/setup-irq.c
> +++ b/drivers/pci/setup-irq.c
> @@ -17,6 +17,14 @@
> #include <linux/ioport.h>
> #include <linux/cache.h>
>
> +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> +{
> +#ifdef CONFIG_PCI_DEBUG
> + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
> + pci_name(dev));
pr_debug()?
Or even better, dev_dbg()?
> +#endif
> + pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
> +}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2012-09-15 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 20:44 [PATCH 1/2] PCI: Annotate pci_fixup_irqs with __devinit Thierry Reding
2012-09-14 20:44 ` [PATCH 2/2] PCI: Provide a default pcibios_update_irq() Thierry Reding
2012-09-15 7:32 ` Geert Uytterhoeven [this message]
2012-09-15 7:53 ` Thierry Reding
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-16 6:50 ` Thierry Reding
2012-09-14 20:53 ` [PATCH 1/2] PCI: Annotate pci_fixup_irqs with __devinit Bjorn Helgaas
2012-09-14 22:35 ` Greg Kroah-Hartman
2012-09-15 7:57 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).