From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Wed, 24 Apr 2019 06:27:43 +0000 Subject: Re: [PATCH] sh: require --Wl,--hash-style=sysv Message-Id: List-Id: References: <20190423202907.234180-1-ndesaulniers@google.com> In-Reply-To: <20190423202907.234180-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nick Desaulniers Cc: Yoshinori Sato , Rich Felker , Andy Lutomirsky , clang-built-linux@googlegroups.com, Masahiro Yamada , Linux-sh list , Linux Kernel Mailing List Hi Nick, On Tue, Apr 23, 2019 at 10:31 PM Nick Desaulniers wrote: > Towards the goal of removing cc-ldoption, prefer ld-option, or better > yet, require --Wl,--hash-style=sysv since the selftest for vdso's > requires DT_HASH. > > Cc: Andy Lutomirsky > Cc: clang-built-linux@googlegroups.com > Suggested-by: Masahiro Yamada > Signed-off-by: Nick Desaulniers Thanks for your patch! > --- a/arch/sh/kernel/vsyscall/Makefile > +++ b/arch/sh/kernel/vsyscall/Makefile > @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@ > > export CPPFLAGS_vsyscall.lds += -P -C -Ush > > -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \ > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv > > SYSCFLAGS_vsyscall-trapa.so = $(vsyscall-flags) What impact does this have on the minimum binutils version needed to compile the kernel? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds