From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 29 Jun 2018 14:30:49 +0000 Subject: Re: [PATCH 2/4] serial: sh-sci: Stop using deprecated dmaengine_terminate_all() Message-Id: List-Id: References: <20180629142513.20743-1-geert+renesas@glider.be> <20180629142513.20743-6-geert+renesas@glider.be> In-Reply-To: <20180629142513.20743-6-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Greg KH , Jiri Slaby , Laurent Pinchart , Ulrich Hecht , Wolfram Sang , "open list:SERIAL DRIVERS" , Linux-Renesas , Linux-sh list On Fri, Jun 29, 2018 at 4:25 PM Geert Uytterhoeven wrote: > As of commit b36f09c3c441a6e5 ("dmaengine: Add transfer termination > synchronization support"), dmaengine_terminate_all() is deprecated. > > Replace calls to dmaengine_terminate_all() in DMA release code by calls > to dmaengine_terminate_sync(), as the latter waits until all running > completion callbacks have finished. > > Replace calls to dmaengine_terminate_all() in DMA failure paths by calls > to dmaengine_terminate_async(), as these are usually done in atomic > context. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/tty/serial/sh-sci.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > index 898c1034cad23a88..061660ccf9442d02 100644 > --- a/drivers/tty/serial/sh-sci.c > +++ b/drivers/tty/serial/sh-sci.c > @@ -1613,7 +1613,7 @@ dev_dbg_dma(port->dev, "%s\n", __func__); > s->chan_rx_saved = s->chan_rx = NULL; > s->cookie_rx[0] = s->cookie_rx[1] = -EINVAL; > WARN(!chan, "RX DMA channel already released\n"); Woops, I had some old versions of the patches lying around, and accidentally sent them with the real series. Sorry for that, the "[x/4]" patches should be ignored. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds