From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Tue, 11 Mar 2014 17:44:21 +0000 Subject: Re: [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework Message-Id: List-Id: References: <1394531952-3905-1-git-send-email-geert@linux-m68k.org> <1802214.NxZUiJcWLG@avalon> <2274545.CyQ67zvVqo@avalon> In-Reply-To: <2274545.CyQ67zvVqo@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: Mark Brown , linux-spi , Linux-sh list , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Magnus Damm Hi Laurent, On Tue, Mar 11, 2014 at 5:32 PM, Laurent Pinchart wrote: > On Tuesday 11 March 2014 17:23:37 Geert Uytterhoeven wrote: >> On Tue, Mar 11, 2014 at 4:55 PM, Laurent Pinchart wrote: >> > Does this require drivers/sh/pm_runtime.c to be compiled in ? >> >> Let's check... >> >> My koelsch-legacy kernel has drivers/sh/pm_runtime.c compiled in. >> My koelsch-reference kernel hasn't. >> >> However, under the -reference kernel many MSTP clocks (incl. MSIOF) >> seem to be enabled all the time, while under -legacy they are enabled and >> disabled on demand. > > Is PM_RUNTIME enabled in both cases ? Yes it is. > There's something fishy in there that we should try to fix without too further > much delay. Ben Dooks has pointed out the problem a couple of months ago, but > the discussion on the mailing list just died. Indeed. I'll look into it next week, unless someone beats me to it. Note that I dropped Ben's patch to include drivers/sh, as I can't boot into userspace with it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds