From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT
Date: Tue, 01 Dec 2015 08:06:17 +0000 [thread overview]
Message-ID: <CAMuHMdXgr5FbS0_L8g0xdesFZ-utPH+G8VgXQKqXZd3t4OsXcw@mail.gmail.com> (raw)
In-Reply-To: <20151201064149.GH16260@verge.net.au>
Hi Simon,
On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote:
>> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman
>> <horms+renesas@verge.net.au> wrote:
>> > Enable the QSPI controller in the alt device tree.
>> >
>> > Based similar work for the silk board by by Vladimir Barinov and
>> > Sergei Shtylyov.
>> >
>> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> Verified against Alt schematics and r8a7794 datasheet.
>>
>> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> I can't verify the FLASH layout. Note that p.11 of
>> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different
>> FLASH layout for the second and third partition.
>
> Thanks. I see the following in v1.9.6 of the BSP[1]. Is it
> the same as the document you referred to above?
>
>
> partition@0 {
> label = "loader";
> reg = <0x00000000 0x00080000>;
> read-only;
> };
> partition@40000 {
> label = "user";
> reg = <0x00080000 0x00580000>;
> read-only;
> };
> partition@440000 {
> label = "flash";
> reg = <0x00600000 0x03a00000>;
> };
>
>
> [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379
No, the document specifies 3 partitions:
- SA0: loader program area, 16 KiB,
- SA1: System area, 16 KiB,
- SA2: User program area, remainder.
FWIW, the unit addresses in the device nodes above are not consistent
with their reg properties.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2015-12-01 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 6:13 [PATCH] ARM: shmobile: alt: Add QSPI device to DT Simon Horman
2015-11-30 8:34 ` Geert Uytterhoeven
2015-12-01 6:41 ` Simon Horman
2015-12-01 8:06 ` Geert Uytterhoeven [this message]
2015-12-18 2:54 ` Simon Horman
2015-12-18 10:07 ` Geert Uytterhoeven
2016-01-03 21:07 ` Simon Horman
2016-01-04 8:59 ` Geert Uytterhoeven
2016-01-04 10:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXgr5FbS0_L8g0xdesFZ-utPH+G8VgXQKqXZd3t4OsXcw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).