From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Date: Fri, 13 Nov 2015 07:46:24 +0000 Subject: Re: [PATCH v2] ARM: xip: Use correct symbol for end of ROM marker Message-Id: List-Id: References: <1447251455-22731-1-git-send-email-chris.brandt@renesas.com> <1447362108-4333-1-git-send-email-chris.brandt@renesas.com> In-Reply-To: <1447362108-4333-1-git-send-email-chris.brandt@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Chris, On Thu, Nov 12, 2015 at 10:01 PM, Chris Brandt wrote: > For an XIP build, _edata_loc, not _etext, represents the end of the > binary image that will be programmed into ROM and mapped into the > MODULES_VADDR area. > With an XIP kernel, nothing is loaded into RAM before boot, meaning > you have to take into account the size of the entire binary image > that was programmed, including the init data values that will be copied > to RAM during kernel boot. > > This fixes the bug where you might lose the end of your kernel area > after page table setup is complete. Thanks for your patch! > Signed-off-by: Chris Brandt > --- > v2 > * Added change for MODULES_VADDR > * Moved extern to new file asm/sections.h > --- > arch/arm/include/asm/sections.h | 8 ++++++++ > arch/arm/kernel/module.c | 2 +- > arch/arm/mm/mmu.c | 4 ++-- > 3 files changed, 11 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/include/asm/sections.h If you create an arm-specific , you also have to remove the line generic-y += sections.h from arch/arm/include/asm/Kbuild. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds