From: Magnus Damm <magnus.damm@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver
Date: Wed, 25 Sep 2013 23:40:03 +0000 [thread overview]
Message-ID: <CANqRtoQCLLvxE5tiHaRLWU3cDTfBfA2D79xsRRKHTSk3U-50bA@mail.gmail.com> (raw)
In-Reply-To: <20130925050647.GG24243@verge.net.au>
On Wed, Sep 25, 2013 at 2:06 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Sep 18, 2013 at 01:53:48PM -0700, Olof Johansson wrote:
>> Hi,
>>
>>
>> On Wed, Sep 18, 2013 at 12:50 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > From: Magnus Damm <damm@opensource.se>
>> >
>> > Include MTU2 in the list of timer drivers that may
>> > be used on mach-shmobile. This driver has previously
>> > only been used by the SH architecture. With this patch
>> > the MTU2 joins TMU and CMT as timer drivers that may be
>> > used on ARM or SH.
>> >
>> > Signed-off-by: Magnus Damm <damm@opensource.se>
>> > ---
>> >
>> > arch/arm/mach-shmobile/Kconfig | 6 ++++++
>> > 1 file changed, 6 insertions(+)
>> >
>> > --- 0004/arch/arm/mach-shmobile/Kconfig
>> > +++ work/arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900
>> > @@ -314,6 +314,12 @@ config SH_TIMER_CMT
>> > help
>> > This enables build of the CMT timer driver.
>> >
>> > +config SH_TIMER_MTU2
>> > + bool "MTU2 timer driver"
>> > + default y
>> > + help
>> > + This enables build of the MTU2 timer driver.
>>
>> It's odd to have the config entry in arch/arm/ when the driver is in
>> drivers/clocksource. I think this entry should be moved to
>> drivers/clocksource/Kconfig for that reason (with appropriate
>> dependencies).
>
> This sounds logical to me.
> Magnus, how do you feel about this?
Keeping it in a single location sounds good to me, but I worry a bit
about how to merge it without any conflicts.
A little while ago did I send out a first rough patch for this:
[PATCH/RFC] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits
Cheers,
/ magnus
prev parent reply other threads:[~2013-09-25 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 19:50 [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver Magnus Damm
2013-09-18 20:53 ` Olof Johansson
2013-09-25 5:06 ` Simon Horman
2013-09-25 23:40 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANqRtoQCLLvxE5tiHaRLWU3cDTfBfA2D79xsRRKHTSk3U-50bA@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).