* [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver
@ 2013-09-18 19:50 Magnus Damm
2013-09-18 20:53 ` Olof Johansson
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2013-09-18 19:50 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Include MTU2 in the list of timer drivers that may
be used on mach-shmobile. This driver has previously
only been used by the SH architecture. With this patch
the MTU2 joins TMU and CMT as timer drivers that may be
used on ARM or SH.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/mach-shmobile/Kconfig | 6 ++++++
1 file changed, 6 insertions(+)
--- 0004/arch/arm/mach-shmobile/Kconfig
+++ work/arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900
@@ -314,6 +314,12 @@ config SH_TIMER_CMT
help
This enables build of the CMT timer driver.
+config SH_TIMER_MTU2
+ bool "MTU2 timer driver"
+ default y
+ help
+ This enables build of the MTU2 timer driver.
+
config SH_TIMER_TMU
bool "TMU timer driver"
default y
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver
2013-09-18 19:50 [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver Magnus Damm
@ 2013-09-18 20:53 ` Olof Johansson
2013-09-25 5:06 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Olof Johansson @ 2013-09-18 20:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, Sep 18, 2013 at 12:50 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Include MTU2 in the list of timer drivers that may
> be used on mach-shmobile. This driver has previously
> only been used by the SH architecture. With this patch
> the MTU2 joins TMU and CMT as timer drivers that may be
> used on ARM or SH.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/mach-shmobile/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- 0004/arch/arm/mach-shmobile/Kconfig
> +++ work/arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900
> @@ -314,6 +314,12 @@ config SH_TIMER_CMT
> help
> This enables build of the CMT timer driver.
>
> +config SH_TIMER_MTU2
> + bool "MTU2 timer driver"
> + default y
> + help
> + This enables build of the MTU2 timer driver.
It's odd to have the config entry in arch/arm/ when the driver is in
drivers/clocksource. I think this entry should be moved to
drivers/clocksource/Kconfig for that reason (with appropriate
dependencies).
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver
2013-09-18 20:53 ` Olof Johansson
@ 2013-09-25 5:06 ` Simon Horman
2013-09-25 23:40 ` Magnus Damm
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2013-09-25 5:06 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 18, 2013 at 01:53:48PM -0700, Olof Johansson wrote:
> Hi,
>
>
> On Wed, Sep 18, 2013 at 12:50 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > From: Magnus Damm <damm@opensource.se>
> >
> > Include MTU2 in the list of timer drivers that may
> > be used on mach-shmobile. This driver has previously
> > only been used by the SH architecture. With this patch
> > the MTU2 joins TMU and CMT as timer drivers that may be
> > used on ARM or SH.
> >
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> > ---
> >
> > arch/arm/mach-shmobile/Kconfig | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > --- 0004/arch/arm/mach-shmobile/Kconfig
> > +++ work/arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900
> > @@ -314,6 +314,12 @@ config SH_TIMER_CMT
> > help
> > This enables build of the CMT timer driver.
> >
> > +config SH_TIMER_MTU2
> > + bool "MTU2 timer driver"
> > + default y
> > + help
> > + This enables build of the MTU2 timer driver.
>
> It's odd to have the config entry in arch/arm/ when the driver is in
> drivers/clocksource. I think this entry should be moved to
> drivers/clocksource/Kconfig for that reason (with appropriate
> dependencies).
This sounds logical to me.
Magnus, how do you feel about this?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver
2013-09-25 5:06 ` Simon Horman
@ 2013-09-25 23:40 ` Magnus Damm
0 siblings, 0 replies; 4+ messages in thread
From: Magnus Damm @ 2013-09-25 23:40 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 25, 2013 at 2:06 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Sep 18, 2013 at 01:53:48PM -0700, Olof Johansson wrote:
>> Hi,
>>
>>
>> On Wed, Sep 18, 2013 at 12:50 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > From: Magnus Damm <damm@opensource.se>
>> >
>> > Include MTU2 in the list of timer drivers that may
>> > be used on mach-shmobile. This driver has previously
>> > only been used by the SH architecture. With this patch
>> > the MTU2 joins TMU and CMT as timer drivers that may be
>> > used on ARM or SH.
>> >
>> > Signed-off-by: Magnus Damm <damm@opensource.se>
>> > ---
>> >
>> > arch/arm/mach-shmobile/Kconfig | 6 ++++++
>> > 1 file changed, 6 insertions(+)
>> >
>> > --- 0004/arch/arm/mach-shmobile/Kconfig
>> > +++ work/arch/arm/mach-shmobile/Kconfig 2013-09-19 04:17:55.000000000 +0900
>> > @@ -314,6 +314,12 @@ config SH_TIMER_CMT
>> > help
>> > This enables build of the CMT timer driver.
>> >
>> > +config SH_TIMER_MTU2
>> > + bool "MTU2 timer driver"
>> > + default y
>> > + help
>> > + This enables build of the MTU2 timer driver.
>>
>> It's odd to have the config entry in arch/arm/ when the driver is in
>> drivers/clocksource. I think this entry should be moved to
>> drivers/clocksource/Kconfig for that reason (with appropriate
>> dependencies).
>
> This sounds logical to me.
> Magnus, how do you feel about this?
Keeping it in a single location sounds good to me, but I worry a bit
about how to merge it without any conflicts.
A little while ago did I send out a first rough patch for this:
[PATCH/RFC] clocksource: Consolidate SH and ARM mach-shmobile Kconfig bits
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-25 23:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 19:50 [PATCH] ARM: shmobile: Allow build of the MTU2 timer driver Magnus Damm
2013-09-18 20:53 ` Olof Johansson
2013-09-25 5:06 ` Simon Horman
2013-09-25 23:40 ` Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).