From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ARM: shmobile: bockw: add DT reference
Date: Wed, 10 Jul 2013 05:33:49 +0000 [thread overview]
Message-ID: <CANqRtoSTSCf8YUbh2QqkQ7x-6ccNkhdARPy9cCvUPx8JSeuYPA@mail.gmail.com> (raw)
In-Reply-To: <87y59fup9u.wl%kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Wed, Jul 10, 2013 at 2:16 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Magnus
>
>> > This patch adds a sample DT-based Bock-W "reference" implementation.
>> > The use of platform-specific C-code should be avoided
>> > with this configuration as much as possible.
>> >
>> > This patch adds new r8a7778_add_dt_devices() which was same stance
>> > of r8a7790_add_dt_devices()
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> > ---
>> > v1 -> v2
>> >
>> > - removed LAN support
>>
>> Thanks for your efforts. It looks fine to me.
>>
>> Acked-by: Magnus Damm <damm@opensource.se>
>>
>> About r8a7778_add_standard_devices() and r8a7778_add_dt_devices(), do
>> you intend to add more device to r8a7778_add_standard_devices()?
>>
>> If the answer is no then I think you should write an incremental patch
>> that simply replaces r8a7778_add_standard_devices() in board-bockw.c
>> with r8a7778_add_dt_devices(), and then you can remove
>> r8a7778_add_standard_devices() from setup-r8a7778.c and r8a7778.h.
>
> I guess we will add DMAEngine support in it ?
> r8a73a4 is such style
Yeah, maybe so. Also, I think other SoCs put SoC-specific devices
without board-specific configuration in this list. On r8a7778 you seem
to handle I2C and HSPI in a different way, but I am not sure why this
special style is needed.
Cheers,
/ magnus
next prev parent reply other threads:[~2013-07-10 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 2:23 [PATCH v2] ARM: shmobile: bockw: add DT reference Kuninori Morimoto
2013-07-10 5:04 ` Magnus Damm
2013-07-10 5:16 ` Kuninori Morimoto
2013-07-10 5:33 ` Magnus Damm [this message]
2013-07-11 3:41 ` Kuninori Morimoto
2013-07-11 4:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANqRtoSTSCf8YUbh2QqkQ7x-6ccNkhdARPy9cCvUPx8JSeuYPA@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).