Re: [PATCH v2 1/6] ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it

[Magnus Damm <magnus.damm@gmail.com>]

Hi Guennadi,

On Sat, Jul 6, 2013 at 12:25 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> Add a DMAC platform device and clock definitions for it on r8a73a4.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>
> v2: preserve the original coding style in r8a73a4_add_standard_devices():
>     use a macro to register a DMA device.
>
>  arch/arm/mach-shmobile/clock-r8a73a4.c        |    4 +-
>  arch/arm/mach-shmobile/include/mach/r8a73a4.h |   15 +++
>  arch/arm/mach-shmobile/setup-r8a73a4.c        |  120 +++++++++++++++++++++++++
>  3 files changed, 138 insertions(+), 1 deletions(-)

I'm quite fine with this patch, but can you please explain why you add
SDHI information in this patch?

Your later patches in the series don't make use of them anyway, and if
so they must be untested. I'd rather not have untested code upstream.
Or do you have any code ready that can extend the SDHI drivers on
r8a73a4 to make use of DMA?

Thanks,

/ magnus