From: Rob Landley <rob@landley.net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] sh_eth: fix TX buffer byte-swapping
Date: Sun, 13 Dec 2015 22:25:17 +0000 [thread overview]
Message-ID: <CAOS_Y6ScbQg-Kh_gNTh2XWKyDEN_uGJt5q1Na5GFDWR9MSbabw@mail.gmail.com> (raw)
In-Reply-To: <4052048.4A561jYI0l@wasted.cogentembedded.com>
On Sun, Dec 13, 2015 at 12:27 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> For the little-endian SH771x kernels the driver has to byte-swap the RX/TX
> buffers, however yet unset physcial address from the TX descriptor is used
> to call sh_eth_soft_swap(). Use 'skb->data' instead...
Rummage rummage rummage...
Ah, my sh4 qemu system has an rtl-8139cp network driver, and the sh2
j-core numato board one is A) big endian, B) has an oddball version
with its own driver.
That's why I haven't hit this.
Rob
next prev parent reply other threads:[~2015-12-13 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 18:27 [PATCH] sh_eth: fix TX buffer byte-swapping Sergei Shtylyov
2015-12-13 22:25 ` Rob Landley [this message]
2015-12-15 5:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOS_Y6ScbQg-Kh_gNTh2XWKyDEN_uGJt5q1Na5GFDWR9MSbabw@mail.gmail.com \
--to=rob@landley.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).