From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-sh@vger.kernel.org
Subject: [PATCH] sh: balance recently added call to local_irq_disable() for
Date: Thu, 06 May 2010 07:17:05 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1005060908110.4557@axis700.grange> (raw)
Commit f533c3d340536198a4889a42a68d6c0d79a504e7
Author: Paul Mundt <lethal@linux-sh.org>
Date: Fri Oct 16 17:20:58 2009 +0900
sh: Idle loop chainsawing for SMP-based light sleep.
added a call to local_irq_disable() to cpu_idle(), which, if the cpuidle driver
is used, now stays unbalanced. This patch re-adds the missing
local_irq_enable().
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
Unfortunately, even after this patch CPU_IDLE is still broken on sh, due
to some later PM changes, so, I'll remove it from all defconfigs with the
following patch.
arch/sh/kernel/cpu/shmobile/pm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/sh/kernel/cpu/shmobile/pm.c b/arch/sh/kernel/cpu/shmobile/pm.c
index e559687..874035f 100644
--- a/arch/sh/kernel/cpu/shmobile/pm.c
+++ b/arch/sh/kernel/cpu/shmobile/pm.c
@@ -61,6 +61,7 @@ void sh_mobile_call_standby(unsigned long mode)
if (mode & SUSP_SH_MMU)
flush_cache_all();
+ local_irq_enable();
/* Let assembly snippet in on-chip memory handle the rest */
standby_onchip_mem(mode, RAM_BASE);
--
1.6.2.4
reply other threads:[~2010-05-06 7:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1005060908110.4557@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).