linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sh: balance recently added call to local_irq_disable() for
@ 2010-05-06  7:17 Guennadi Liakhovetski
  0 siblings, 0 replies; only message in thread
From: Guennadi Liakhovetski @ 2010-05-06  7:17 UTC (permalink / raw)
  To: linux-sh

Commit f533c3d340536198a4889a42a68d6c0d79a504e7
Author: Paul Mundt <lethal@linux-sh.org>
Date:   Fri Oct 16 17:20:58 2009 +0900

    sh: Idle loop chainsawing for SMP-based light sleep.

added a call to local_irq_disable() to cpu_idle(), which, if the cpuidle driver
is used, now stays unbalanced. This patch re-adds the missing
local_irq_enable().

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---

Unfortunately, even after this patch CPU_IDLE is still broken on sh, due 
to some later PM changes, so, I'll remove it from all defconfigs with the 
following patch.

 arch/sh/kernel/cpu/shmobile/pm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/sh/kernel/cpu/shmobile/pm.c b/arch/sh/kernel/cpu/shmobile/pm.c
index e559687..874035f 100644
--- a/arch/sh/kernel/cpu/shmobile/pm.c
+++ b/arch/sh/kernel/cpu/shmobile/pm.c
@@ -61,6 +61,7 @@ void sh_mobile_call_standby(unsigned long mode)
 	if (mode & SUSP_SH_MMU)
 		flush_cache_all();
 
+	local_irq_enable();
 	/* Let assembly snippet in on-chip memory handle the rest */
 	standby_onchip_mem(mode, RAM_BASE);
 
-- 
1.6.2.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-06  7:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06  7:17 [PATCH] sh: balance recently added call to local_irq_disable() for Guennadi Liakhovetski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).