From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sound/soc/sh/siu: Fixed undefined dma_length of scatter
Date: Fri, 17 Sep 2010 10:07:20 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1009171205250.4988@axis700.grange> (raw)
In-Reply-To: <4C3C7E45.8010102@emtrion.de>
Paul, this patch is also required for 2.6.36, AFAICS, you've only merged
it for 2.6.37?
Tested-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
On Tue, 13 Jul 2010, Markus Pietrek wrote:
>
> Please use this patch. The first patch was based on a modified driver where sg is provided as a pointer and not as a local variable.
>
> Signed-off-by: Markus Pietrek <markus.pietrek@emtrion.de>
> ---
> sound/soc/sh/siu_pcm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/sh/siu_pcm.c b/sound/soc/sh/siu_pcm.c
> index 36170be..b0ccd0b 100644
> --- a/sound/soc/sh/siu_pcm.c
> +++ b/sound/soc/sh/siu_pcm.c
> @@ -127,6 +127,7 @@ static int siu_pcm_wr_set(struct siu_port *port_info,
> sg_init_table(&sg, 1);
> sg_set_page(&sg, pfn_to_page(PFN_DOWN(buff)),
> size, offset_in_page(buff));
> + sg_dma_len(&sg) = size;
> sg_dma_address(&sg) = buff;
>
> desc = siu_stream->chan->device->device_prep_slave_sg(siu_stream->chan,
> @@ -176,6 +177,7 @@ static int siu_pcm_rd_set(struct siu_port *port_info,
> sg_init_table(&sg, 1);
> sg_set_page(&sg, pfn_to_page(PFN_DOWN(buff)),
> size, offset_in_page(buff));
> + sg_dma_len(&sg) = size;
> sg_dma_address(&sg) = buff;
>
> desc = siu_stream->chan->device->device_prep_slave_sg(siu_stream->chan,
>
> _____________________________________
>
> Amtsgericht Mannheim
> HRB 110 300
> Geschäftsführer: Dieter Baur, Ramona Maurer
> _____________________________________
>
> Important Note:
> - This e-mail may contain trade secrets or privileged, undisclosed or otherwise confidential information.
> - If you have received this e-mail in error, you are hereby notified that any review, copying or distribution of it is strictly prohibited.
> - Please inform us immediately and destroy the original transmittal.
>
> Thank you for your cooperation.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
prev parent reply other threads:[~2010-09-17 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 14:55 [PATCH] sound/soc/sh/siu: Fixed undefined dma_length of scatter gather Markus Pietrek
2010-07-13 15:12 ` [PATCH] sound/soc/sh/siu: Fixed undefined dma_length of scatter Markus Pietrek
2010-09-17 10:07 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1009171205250.4988@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).