From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
Chris Ball <cjb@laptop.org>, Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD
Date: Sat, 12 Mar 2011 22:48:26 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1103122347270.28741@axis700.grange> (raw)
In-Reply-To: <AANLkTinQB2NB---0o65Uy-axApw9DwPZoMeMBc=qmvSC@mail.gmail.com>
On Sun, 13 Mar 2011, Magnus Damm wrote:
> On Fri, Mar 11, 2011 at 4:51 PM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > TMIO MMC chips contain an SD / SDIO IP core from Panasonic, similar to
> > the one, used in MN5774 and other MN57xx controllers. These IP cores are
> > included in many multifunction devices, in sh-mobile chips from Renesas,
> > in the latter case they can also use DMA. Some sh-mobile implementations
> > also have some other specialities, that MFD-based solutions don't have.
> > This makes supporting all these features in a monolithic driver inconveniet
> > and error-prone. This patch splits the driver into 3 parts: the core,
> > the MFD glue and the DMA support. In case of a modular build, two modules
> > will be built: mmc_tmio_core and mmc_tmio.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
>
> Thanks for your work on this, I'm happy to see these patches because
> they make it easier for me to add multi-interrupt source to the SDHI
> portion - something that is needed for sh73a0.
>
> > drivers/mmc/host/Kconfig | 4 +
> > drivers/mmc/host/Makefile | 3 +
> > drivers/mmc/host/tmio_mmc.c | 1303 +--------------------------------------
> > drivers/mmc/host/tmio_mmc.h | 152 +++++
> > drivers/mmc/host/tmio_mmc_dma.c | 302 +++++++++
> > drivers/mmc/host/tmio_mmc_pio.c | 923 +++++++++++++++++++++++++++
> > 6 files changed, 1402 insertions(+), 1285 deletions(-)
> > create mode 100644 drivers/mmc/host/tmio_mmc.h
> > create mode 100644 drivers/mmc/host/tmio_mmc_dma.c
> > create mode 100644 drivers/mmc/host/tmio_mmc_pio.c
>
> Something is wrong with this patch. The Makefile adds tmio_mmc_core.c
> but it's not part of the diffstat above. Perhaps you're posting an
> older version of the patch?
No, the Makefile is adding tmio_mmc_core.o:
diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
index 30aa686..79c42dd 100644
--- a/drivers/mmc/host/Makefile
+++ b/drivers/mmc/host/Makefile
@@ -29,6 +29,9 @@ endif
obj-$(CONFIG_MMC_S3C) += s3cmci.o
obj-$(CONFIG_MMC_SDRICOH_CS) += sdricoh_cs.o
obj-$(CONFIG_MMC_TMIO) += tmio_mmc.o
+obj-$(CONFIG_MMC_TMIO_CORE) += tmio_mmc_core.o
+tmio_mmc_core-y := tmio_mmc_pio.o
+tmio_mmc_core-$(CONFIG_TMIO_MMC_DMA) += tmio_mmc_dma.o
obj-$(CONFIG_MMC_CB710) += cb710-mmc.o
obj-$(CONFIG_MMC_VIA_SDMMC) += via-sdmmc.o
obj-$(CONFIG_SDH_BFIN) += bfin_sdh.o
which is linked from two source files. Looks correct to me.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2011-03-12 22:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 7:51 [PATCH 0/6] mmc: split the tmio driver into several modules Guennadi Liakhovetski
2011-03-11 7:51 ` [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD glue Guennadi Liakhovetski
2011-03-12 16:05 ` Magnus Damm
2011-03-12 22:48 ` Guennadi Liakhovetski [this message]
2011-03-13 3:57 ` Magnus Damm
2011-03-13 22:51 ` [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD Guennadi Liakhovetski
2011-03-15 9:01 ` [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD glue Magnus Damm
2011-03-16 11:09 ` Ian Molton
2011-03-16 12:37 ` Magnus Damm
2011-03-21 11:19 ` [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 2/6] sh: ecovec: use the CONFIG_MMC_TMIO symbols instead of Guennadi Liakhovetski
2011-03-12 16:18 ` [PATCH 2/6] sh: ecovec: use the CONFIG_MMC_TMIO symbols instead Magnus Damm
2011-03-12 23:00 ` Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 3/6] mmc: tmio: convert the SDHI MMC driver from MFD to a Guennadi Liakhovetski
2011-03-13 4:14 ` Magnus Damm
2011-03-14 8:01 ` [PATCH 3/6] mmc: tmio: convert the SDHI MMC driver from MFD to Guennadi Liakhovetski
2011-03-15 9:09 ` [PATCH 3/6] mmc: tmio: convert the SDHI MMC driver from MFD to a Magnus Damm
2011-03-11 7:52 ` [PATCH 4/6] ARM: mach-shmobile: convert boards to use Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 5/6] sh: convert boards to use linux/mmc/sh_mobile_sdhi.h Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 6/6] mfd: remove now redundant sh_mobile_sdhi.h header Guennadi Liakhovetski
2011-03-15 21:25 ` [PATCH 0/6] mmc: split the tmio driver into several modules Ian Molton
2011-03-21 11:38 ` Guennadi Liakhovetski
2011-03-22 5:31 ` Simon Horman
2011-03-22 12:28 ` Paul Mundt
2011-03-22 22:06 ` Simon Horman
2011-03-23 14:54 ` Paul Mundt
2011-03-23 22:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1103122347270.28741@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=cjb@laptop.org \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox