linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: linux-media@vger.kernel.org, Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
Date: Thu, 16 Oct 2014 20:27:13 +0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1410162222550.16927@axis700.grange> (raw)
In-Reply-To: <1413271224-9792-1-git-send-email-ykaneko0929@gmail.com>

Hello,

Thanks for the patches. Could you please fold these two into one - they 
really don't deserve to be separated. As for your other series - patches 
there look mostly good - from just a formal review. If you don't mind, 
I'll adjust a couple of cosmetic issues like missing curly braces in 

	if (a)
		x();
	else {
		y();
		z();
	}

or multiline comments or similar minor things.

Thanks
Guennadi

On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote:

> This series is against master branch of linuxtv.org/media_tree.git.
> 
> Koji Matsuoka (2):
>   media: soc_camera: rcar_vin: Add r8a7794 device support
>   media: soc_camera: rcar_vin: Add r8a7793 device support
> 
>  drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2014-10-16 20:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14  7:20 [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support Yoshihiro Kaneko
2014-10-14  7:20 ` [PATCH 1/2] media: soc_camera: rcar_vin: Add r8a7794 " Yoshihiro Kaneko
2014-10-14  7:20 ` [PATCH 2/2] media: soc_camera: rcar_vin: Add r8a7793 " Yoshihiro Kaneko
2014-10-16  5:19 ` [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, " Simon Horman
2014-10-16 20:27 ` Guennadi Liakhovetski [this message]
2014-10-17  6:02   ` Simon Horman
2014-10-17  6:44     ` Yoshihiro Kaneko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1410162222550.16927@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=horms@verge.net.au \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).