From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guennadi Liakhovetski Date: Thu, 16 Oct 2014 20:27:13 +0000 Subject: Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support Message-Id: List-Id: References: <1413271224-9792-1-git-send-email-ykaneko0929@gmail.com> In-Reply-To: <1413271224-9792-1-git-send-email-ykaneko0929@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshihiro Kaneko Cc: linux-media@vger.kernel.org, Simon Horman , Magnus Damm , linux-sh@vger.kernel.org Hello, Thanks for the patches. Could you please fold these two into one - they really don't deserve to be separated. As for your other series - patches there look mostly good - from just a formal review. If you don't mind, I'll adjust a couple of cosmetic issues like missing curly braces in if (a) x(); else { y(); z(); } or multiline comments or similar minor things. Thanks Guennadi On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote: > This series is against master branch of linuxtv.org/media_tree.git. > > Koji Matsuoka (2): > media: soc_camera: rcar_vin: Add r8a7794 device support > media: soc_camera: rcar_vin: Add r8a7793 device support > > drivers/media/platform/soc_camera/rcar_vin.c | 2 ++ > 1 file changed, 2 insertions(+) > > -- > 1.9.1 >