From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD8BECAAD5 for ; Fri, 26 Aug 2022 14:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236491AbiHZOs2 (ORCPT ); Fri, 26 Aug 2022 10:48:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343691AbiHZOsQ (ORCPT ); Fri, 26 Aug 2022 10:48:16 -0400 X-Greylist: delayed 62 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 26 Aug 2022 07:48:15 PDT Received: from mailrelay2-1.pub.mailoutpod1-cph3.one.com (mailrelay2-1.pub.mailoutpod1-cph3.one.com [46.30.210.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F4CED8E2C for ; Fri, 26 Aug 2022 07:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=pzSEnzVb4PRuwPohD2SDHsa5KY0tRkBlHuhkY0oHs0w=; b=NCRe3O/xZCHJ8hDEpD57d6zrmZ/D/l0pxGva3S+GafoGTaEBI8V+8dRJcau2lXRHDYLk3R1tpxP1j 3KhToFhOZVyitlnJ0xRfBBHfLRdUC92ngLyYi8++VZngl+6FIPMMSswvmOKlwmrA48SEArDfjlrrZp aLUYNtoPbfHie2QZuWN/5gmc96n89BeYnrY4HhmXJ0VYbMK/Nwimvglfg4ZslyKY8HJv9B0kGS+jUd iAj6qBZTfiE8K/3fT3d5xnIszRsKWAcgiOTrubWRizGAPwPa3VkkroaVH+3Yp57Mf7SsdGZtyGg98g yEaoCAI90mioch8sotzXt8Sz2DOGFiA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=pzSEnzVb4PRuwPohD2SDHsa5KY0tRkBlHuhkY0oHs0w=; b=czLkABglyklPhRImctvsIg7tPPnc0HaIPVvkP1cQzOjoIxLxHBn86D/l7MTIWNazZ6K+XJ8mOPOkH 5qB81ZOBw== X-HalOne-Cookie: f226e6ab43f82fd861952f49718ba8a608aa1fbd X-HalOne-ID: f6029a30-254d-11ed-a920-d0431ea8a290 Received: from mailproxy3.cst.dirpod4-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay2.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id f6029a30-254d-11ed-a920-d0431ea8a290; Fri, 26 Aug 2022 14:47:09 +0000 (UTC) Date: Fri, 26 Aug 2022 16:47:07 +0200 From: Sam Ravnborg To: Conor Dooley Cc: Michal Simek , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Arnd Bergmann , Geert Uytterhoeven , Conor Dooley , Kees Cook , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 5/6] sparc: use the asm-generic version of cpuinfo_op Message-ID: References: <20220821113512.2056409-1-mail@conchuod.ie> <20220821113512.2056409-6-mail@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220821113512.2056409-6-mail@conchuod.ie> Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Hi Conor. Thanks for this nice simplification, but I think you can make it even better. On Sun, Aug 21, 2022 at 12:35:12PM +0100, Conor Dooley wrote: > From: Conor Dooley > > There's little point in duplicating the declaration of cpuinfo_op now > that there's a shared version of it, so drop it & include the generic > header. > > Signed-off-by: Conor Dooley > --- > arch/sparc/include/asm/cpudata.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/sparc/include/asm/cpudata.h b/arch/sparc/include/asm/cpudata.h > index d213165ee713..af6ef3c028a9 100644 > --- a/arch/sparc/include/asm/cpudata.h > +++ b/arch/sparc/include/asm/cpudata.h > @@ -6,8 +6,7 @@ > > #include > #include > - > -extern const struct seq_operations cpuinfo_op; > +#include Since the header file did not need then it should not need it now after deleting stuff. The better fix is to add the missing include to arch/sparc/kernel/cpu.c, where we have the user of it. A header file should include what it needs, and no more. I looked only at this patch, this comment may also be relevant for the other patches. Sam