From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksa Sarai Date: Tue, 11 Jul 2017 14:45:36 +0000 Subject: Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition Message-Id: List-Id: References: <20170711001207.GA11642@glebfm.cloud.tilaa.com> <063D6719AE5E284EB5DD2968C1650D6DD003758C@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD003758C@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Laight , 'Gleb Fotengauer-Malinovskiy' , Greg Kroah-Hartman Cc: "linux-arch@vger.kernel.org" , "linux-mips@linux-mips.org" , Valentin Rothberg , "linux-parisc@vger.kernel.org" , Arnd Bergmann , "linux-sh@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "linux-alpha@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Dmitry V. Levin" , Jiri Slaby , "sparclinux@vger.kernel.org" , Christian Brauner , "linuxppc-dev@lists.ozlabs.org" >> Sent: 11 July 2017 01:12 >> This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag >> because it doesn't copy anything from/to userspace to access the >> argument. >> >> Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl") > ... >> -#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */ >> +#define TIOCGPTPEER _IO('T', 0x41) /* Safely open the slave */ > > This is a user API change. When was the ioctl added? It was just pulled this merge window (4.13-rc1). % git tag --contains 54ebbfb1603415d9953c150535850d30609ef077 % -- Aleksa Sarai Software Engineer (Containers) SUSE Linux GmbH https://www.cyphar.com/